Re: [Kimchi-devel] [PATCH][Wok] Issue #116: Suggestion to check spec guidelines

On 06/16/2016 03:48 PM, Aline Manera wrote: > > > On 06/14/2016 12:11 AM, Ramon Medeiros wrote: >> Run rpmlint on check-local >> >> Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com&gt; >> --- >> Makefile.am | 1 + >> check_spec_errors.sh | 34 ++++++++++++++++++++++++++++++++++ >> docs/fedora-deps.md | 2 +- >> docs/opensuse-deps.md | 2 +- >> 4 files changed, 37 insertions(+), 2 deletions(-) >> create mode 100755 check_spec_errors.sh >> >> diff --git a/Makefile.am b/Makefile.am >> index 325d0c9..579f707 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -69,6 +69,7 @@ check-local: >> echo "Check IBM license header and copyright date ..." ; \ >> /bin/bash check-IBM-license-header.sh >> ; \ >> fi >> + /bin/bash check_spec_errors.sh; >> >> # Link built mo files in the source tree to enable use of >> translations from >> # within the source tree >> diff --git a/check_spec_errors.sh b/check_spec_errors.sh >> new file mode 100755 >> index 0000000..fa67ced >> --- /dev/null >> +++ b/check_spec_errors.sh >> @@ -0,0 +1,34 @@ >> +#!/bin/bash >> + >> +# >> +# Project Wok >> +# >> +# Copyright IBM Corp, 2015-2016 >> +# > > Wrong date. Please, run 'make check-local' to confirm the copyright > is right before submitting a patch. > The 'make check-local' updates the copyright automatically for you, > you just need to add the changes to your commit. > I will do that for you *this* time before applying upstream. >> +# This library is free software; you can redistribute it and/or >> +# modify it under the terms of the GNU Lesser General Public >> +# License as published by the Free Software Foundation; either >> +# version 2.1 of the License, or (at your option) any later version. >> +# >> +# This library is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> +# Lesser General Public License for more details. >> +# >> +# You should have received a copy of the GNU Lesser General Public >> +# License along with this library; if not, write to the Free Software >> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA >> 02110-1301 USA >> + >> +# create links >> +cp contrib/wok.spec.fedora contrib/wok_fedora.spec >> +cp contrib/wok.spec.suse contrib/wok_suse.spec >> + >> +# run checking >> +rpmlint contrib/wok_fedora.spec >> +rpmlint contrib/wok_suse.spec >> +

>> +# remove links >> +rm contrib/wok_fedora.spec >> +rm contrib/wok_suse.spec >> + >> + >> diff --git a/docs/fedora-deps.md b/docs/fedora-deps.md >> index e665cdb..260390e 100644 >> --- a/docs/fedora-deps.md >> +++ b/docs/fedora-deps.md >> @@ -42,7 +42,7 @@ Packages required for UI development >> Packages required for tests >> --------------------------- >> >> - $ sudo yum install pyflakes python-pep8 python-requests >> + $ sudo yum install pyflakes python-pep8 python-requests rpmlint >> >> # For RHEL systems, install the additional packages: >> $ sudo yum install python-unittest2 >> diff --git a/docs/opensuse-deps.md b/docs/opensuse-deps.md >> index 4fe3876..7fe1763 100644 >> --- a/docs/opensuse-deps.md >> +++ b/docs/opensuse-deps.md >> @@ -29,4 +29,4 @@ Packages required for UI development >> Packages required for tests >> --------------------------- >> >> - $ sudo zypper install python-pyflakes python-pep8 python-requests >> + $ sudo zypper install python-pyflakes python-pep8 >> python-requests rpmlint > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel > _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel