Reviewed-by: Aline Manera <alinefm@linux.vnet.ibm.com> Tested-by: Aline Manera <alinefm@linux.vnet.ibm.com> On 01/23/2014 11:38 PM, shaohef@linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>
V3 -> V4 rebase fix typo move the improvement function from src/kimchi/utils.py to src/kimchi/control/utils.py
V2 -> V3 use the CapWords convention to name class name. add the import statement in alphabetical order
use __import__ to import the moudle instead of imp.load_module imp.load_module does more than importing the module: if the module was already imported, it is equivalent to a reload()!
we can use the imp.load_module as follow: try: module = sys.modules[module_name] except KeyError: mod_fobj, mod_absp, mod_desc = imp.find_module(mod_name, [path]) module = imp.load_module(module_name, mod_fobj, mod_absp, mod_desc)
V1 -> V2 fix typo. remove print use url_auth instead of _url_sub_node_auth improve the commit description
add a method to load root sub collections/resouces automatically
ShaoHe Feng (4): improve controller: add a method to load root sub collections/resouces automatically improve controller: tag the collections/resouces of root with @UrlSubNode improve controller: Root loads collections/resouces automatically improve controller: set authentication automatically
src/kimchi/control/__init__.py | 8 ++++++++ src/kimchi/control/config.py | 2 ++ src/kimchi/control/debugreports.py | 2 ++ src/kimchi/control/host.py | 2 ++ src/kimchi/control/interfaces.py | 2 ++ src/kimchi/control/networks.py | 2 ++ src/kimchi/control/plugins.py | 2 ++ src/kimchi/control/storagepools.py | 2 ++ src/kimchi/control/tasks.py | 2 ++ src/kimchi/control/templates.py | 2 ++ src/kimchi/control/utils.py | 39 ++++++++++++++++++++++++++++++++++++++ src/kimchi/control/vms.py | 3 ++- src/kimchi/root.py | 28 +++++---------------------- src/kimchi/server.py | 12 +++++------- 14 files changed, 77 insertions(+), 31 deletions(-)