Re: [Kimchi-devel] [PATCH 0/2] Pause/resume support in UI
Hi Socorro,
UI looks good and is working.
I have some comments:
- Can you change the resume icon in the guest preview square ? For
me, in Firefox, it is gray and had to see. If it is green as the bigger
one would be better
- Is there any reason to disable 'Connect' button, when the vm is
paused ?
- I see some problems in the code, see further emails
Rodrigo
On 05/28/2015 03:20 PM, Socorro Stoppler wrote:
From: Socorro Stoppler <socorrob(a)us.ibm.com>
Add support for pause/resume VM via the UI
Socorro Stoppler (2):
First changes for pause/resume UI
Add support for Pause/Resume UI
ui/css/theme-default/button.css | 20 +++++
ui/css/theme-default/list.css | 6 ++
ui/images/theme-default/ac22_pause.png | Bin 0 -> 1219 bytes
ui/images/theme-default/ac22_pause_grey.png | Bin 0 -> 1175 bytes
ui/images/theme-default/ac24_resume.png | Bin 0 -> 1341 bytes
ui/images/theme-default/ac24_resume_grey.png | Bin 0 -> 1282 bytes
ui/js/src/kimchi.api.js | 23 ++++++
ui/js/src/kimchi.guest_main.js | 114 +++++++++++++++++++++++----
ui/pages/guest.html.tmpl | 4 +
9 files changed, 152 insertions(+), 15 deletions(-)
create mode 100644 ui/images/theme-default/ac22_pause.png
create mode 100644 ui/images/theme-default/ac22_pause_grey.png
create mode 100644 ui/images/theme-default/ac24_resume.png
create mode 100644 ui/images/theme-default/ac24_resume_grey.png