Re: [Kimchi-devel] [PATCH V2] network improvment: add vms field

You also need to update the tests:

====================================================================== FAIL: test_get_networks (test_rest.HttpsRestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/alinefm/kimchi/tests/test_rest.py", line 818, in test_get_networks self.assertEquals(1, len(networks)) AssertionError: 1 != 3 ====================================================================== FAIL: test_network_action (test_rest.HttpsRestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/alinefm/kimchi/tests/test_rest.py", line 850, in test_network_action self.assertEquals(201, resp.status) AssertionError: 201 != 500 ====================================================================== FAIL: test_get_networks (test_rest.RestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/alinefm/kimchi/tests/test_rest.py", line 818, in test_get_networks self.assertEquals(1, len(networks)) AssertionError: 1 != 3 ====================================================================== FAIL: test_network_action (test_rest.RestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/alinefm/kimchi/tests/test_rest.py", line 850, in test_network_action self.assertEquals(201, resp.status) AssertionError: 201 != 500 ---------------------------------------------------------------------- Ran 112 tests in 87.340s FAILED (failures=4) On 01/03/2014 07:23 AM, shaohef(a)linux.vnet.ibm.com wrote: > From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt; > > V1 -> V2 > set the flags argument of listAllDomains as 0 explicitly. > For in some distros: > $ pydoc libvirt.virConnect.listAllDomains > libvirt.virConnect.listAllDomains = listAllDomains(self, flags) \ > unbound libvirt.virConnect method > > And in other distros: > $ pydoc libvirt.virConnect.listAllDomains > libvirt.virConnect.listAllDomains = listAllDomains(self, flags=0) \ > unbound libvirt.virConnect method > > ShaoHe Feng (1): > network improvment: add vms field > > docs/API.md | 1 + > src/kimchi/control/networks.py | 1 + > src/kimchi/model.py | 15 +++++++++++++++ > 3 files changed, 17 insertions(+) >