Re: [Kimchi-devel] [PATCH] bug fix: display kimchi icon instead of cherrypy icon
On 02/13/2014 10:03 PM, CrÃstian Viana wrote:
AFAIU, that setting overrides the icon for everything served by
cherrypy. If that's right, can you also remove the following line from
ui/pages/kimchi-ui.html.tmpl?
<link rel="shortcut icon" href="images/logo.ico">
Or is it still needed?
It's needed. They are all for browser compatibility.
Am 13-02-2014 11:53, schrieb shaohef(a)linux.vnet.ibm.com:
> From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
>
> When we start a VNC window, the favicon.ico is always cherrypy icon.
>
> Actually we open any page:
> such as:
> http://192.168.1.117:8000/error
>
> the favicon.ico is also a cherrypy icon.
>
> This patch fix this bug.
>
> Ref:
> http://docs.cherrypy.org/en/latest/progguide/files/favicon.html
>
> Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel