Re: [Kimchi-devel] [PATCH] Support to upload ISO

On 06/12/2014 05:55 AM, ssdxiao wrote: > > Hi, > Agree with Royce. > This is the use case: > Machine A(where the kimchid is running). > Machine B (the browser which is connetting to the machine A's kimchi). > > Step1: upload the iso(locate on the B) from B to A. > Step2: search the iso in A and create a template. > Step3: use the template boot a vm. > Got it. Thanks! I got messed as I tested it locally. =) About the patch, I agree if Royce - we need to improve the UI. You should split your patch set in small patches. I'd say 3 patches: 1) For the imported code That way we easily identify which patches we need to really review the code 2) For backend code 3) For UI code You added a new optional to create a template but it only uploads the ISO to Kimchi server. I'd expect it to upload and create the template itself The API should be: 1) POST /storagepools/<ootb-pool>/upload {'file': <filename>} This URI will be responsible to upload the file to Kimchi server and it will be only available for the storagepool resource 2) POST /templates/ {'cdrom': <path to file uploaded earlier>}

_______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel