A few interface suggestions: Repositories table: Remove "Repos" string from column headers. It should be obvious this data relates to repositories from the section title Remove numerical column, making the ID column non-scrollable Combine Base URL and args into a single URL. Show full URLs onHover or via some gesture Reorder columns as follows. Column names & order would be: ID, Name, Enabled, URL, Mirror, GPG Check, GPG Key Edit window: Make edit window field names match column names with the possible exception of combining URL and Args Enable the radio buttons for enabled, mirror Will we ever want a value in GPG key, but GPG check disabled? If not, combine the 2 fields such that specifying a key implies they key should be checked, and vice versa. Add a Repository window: If it ever makes sense to have GPG Check false, but GPG Key filled then we need to add the "Check" boolean to this window Can we determine if the URL is a mirror programatically? If so we should. Why is "Base URL" the only required field? When I submit a new repo with an invalid URL, nothing appears to happen. When I submit one with only a valid URL, a number of fields are subsequently displayed as null. The dynamically generated ID and Name could be friendlier. On 03/04/2014 05:33 AM, Hongliang Wang wrote:
Add host repositories management in this patch set.
Hongliang Wang (4): [UI] Add i18n Strings for Repositories Management [UI] Add API Support for Repositories Management [UI] Add/Edit Repository Support [UI] Integrate Repositories Management into Host Tab
po/POTFILES.in | 2 + ui/css/theme-default/host.css | 44 +++++++++++ ui/css/theme-default/repository-add.css | 39 ++++++++++ ui/css/theme-default/repository-edit.css | 69 +++++++++++++++++ ui/js/src/kimchi.api.js | 61 +++++++++++++++ ui/js/src/kimchi.host.js | 126 +++++++++++++++++++++++++++++++ ui/js/src/kimchi.repository_add_main.js | 84 +++++++++++++++++++++ ui/js/src/kimchi.repository_edit_main.js | 85 +++++++++++++++++++++ ui/pages/i18n.html.tmpl | 18 +++++ ui/pages/repository-add.html.tmpl | 104 +++++++++++++++++++++++++ ui/pages/repository-edit.html.tmpl | 121 +++++++++++++++++++++++++++++ ui/pages/tabs/host.html.tmpl | 13 ++++ 12 files changed, 766 insertions(+) create mode 100644 ui/css/theme-default/repository-add.css create mode 100644 ui/css/theme-default/repository-edit.css create mode 100644 ui/js/src/kimchi.repository_add_main.js create mode 100644 ui/js/src/kimchi.repository_edit_main.js create mode 100644 ui/pages/repository-add.html.tmpl create mode 100644 ui/pages/repository-edit.html.tmpl
-- Adam King <rak@linux.vnet.ibm.com> IBM CSI