Re: [Kimchi-devel] [PATCH] Plugins UI: Correctly Load Plugin Tabs

Reviewed-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com&gt; Sorry for my last replies! Please ignore them. I just ran your code and it worked well and Array.prototype.push.apply() has better performance than Array.concat(). Thanks for the fix.

On 04/03/2014 03:51 PM, zhshzhou(a)linux.vnet.ibm.com wrote: > From: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt; > > In ui/js/src/kimchi.main.js we fetch all plugin tabs and concat them to > the tabs array. However array.concat does not work in place, it creates > a new array to store the result, so it does not correctly update the > tabs array. The plugin tabs are not loaded at all. > > This patch fixes the problem by using tabs.push.apply(tabs, pluginTabs) . > > Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com&gt; > --- > ui/js/src/kimchi.main.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/js/src/kimchi.main.js b/ui/js/src/kimchi.main.js > index 9b0acbf..78206bf 100644 > --- a/ui/js/src/kimchi.main.js > +++ b/ui/js/src/kimchi.main.js > @@ -72,7 +72,7 @@ kimchi.main = function() { > var url = kimchi.template(pluginConfigUrl, { > plugin: p > }); > - tabs.concat(retrieveTabs(url)); > + tabs.push.apply(tabs, retrieveTabs(url)); > }); > > var firstTabPath = tabs[0] && tabs[0]['path'];