Re: [Kimchi-devel] [PATCH ] Fix screenshots and debug reports paths.
On 02/27/2014 11:39 PM, Shu Ming wrote:
2014/2/27 21:47, Paulo Ricardo Paz Vital:
> Ming,
>
> Your patch solves only the DebugReports problem, while Leonardo's patch
> solves any difference between what UI expects and backend sets.
I was planing to send screenshot patch later after all of us agree
with the method to fix DebugReports, anyway this is another issue not
directly linked to my point.
Yes,
Usually the author make more investigations than the reviewer.
But sometimes he may not tell more the details, such as what
investigation he make, and what he will do the next step.
if reviewer want to better, he should also make more investigation, but
this may take a reviewer long time.
reviewer discusses with author is a good way.
My point was that:
1) when one people already worked on something, the later one should
communicate with the former one to avoid duplicate effort
2) The patch should have some soaking time to be merged, say 24 hours,
and people in other timezone can get an opportunity to review it.
>
> In addition, IMO the point you mentioned about not expose host file
> system to the front is the root cause of this bug. Many UI paths were
> broken because the paths set up by backend was not used or followed.
In most cases ,we should use relative path to hide the host file
systems from the front users. Only if it must, the absolute path can
be used. I don't like the idea to change all the relative static path
to absolute ones. IMO, we can only use absolute path for the
debugreport and screenshot path. Even better, we can take more effort
to re-organize the path to have a reasonable root for all of the path
including debugreport and screenshot paths.
>
> Best regards,
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel
--
Thanks and best regards!
Sheldon Feng(冯少合)<shaohef(a)linux.vnet.ibm.com>
IBM Linux Technology Center