Hi, just confirmed here: if you switch or create the vm with SPICE, the trash will stay there, even you changing to vnc. The only change in xml is this line: @@ -75,7 +73,7 @@ </channel> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> - <graphics type='spice' autoport='yes' listen='127.0.0.1'> + <graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1'> The "trash", is this line: <channel type='spicevmc'> <target type='virtio' name='com.redhat.spice.0'/> <address type='virtio-serial' controller='0' bus='0' port='1'/> </channel> That stays in xml, but seems to no make trouble on guest. On 08/30/2016 01:49 PM, Aline Manera wrote:
On 08/30/2016 01:43 PM, Ramon Medeiros wrote:
Just retest right now to make sure.
I have a opensuse vm running on spice.
1) turned off it 2) Run PUT on REST API to update it to vnc 3) Turn on 4) opened console on vnc without issues. 5) turned off again 6) Switch to spice 7) running without issues again
Tested on my laptop: Fedora 23 x86_64
Please, check if the guest XML does not have any leftover related to those console type changes.
On 08/30/2016 01:23 PM, Aline Manera wrote:
Hi Ramon,
Maybe something else is needed here.
When I have a guest configured with SPICE console, the guest XML is something like below:
<graphics type='spice' autoport='yes' listen='127.0.0.1'> <channel type='spicevmc'> <target type='virtio' name='com.redhat.spice.0'/> </channel>
And for a guest with VNC console, the guest XML has:
<graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1'>
From this patch, I am seeing you changing only the type parameter in the graphics tag.
Shouldn't the <channel type='spicevmc'> node be removed when changing from SPICE to VNC? What about the port number needed for VNC configuration?
Is all that being done automatically through libvirt? Have you confirmed that the console kept working after changing the console type?
Regards, Aline Manera
On 08/23/2016 01:47 PM, Ramon Medeiros wrote:
Changes:
v2: Fix typos Add tests
Ramon Medeiros (2): Issue #836: Allow user change guest graphics type Create test to verify graphics type change
API.json | 6 ++++++ docs/API.md | 1 + i18n.py | 2 +- model/vms.py | 10 ++++++++++ tests/test_model.py | 18 +++++++----------- 5 files changed, 25 insertions(+), 12 deletions(-)
-- Ramon Nunes Medeiros Kimchi Developer Linux Technology Center Brazil IBM Systems & Technology Group Phone : +55 19 2132 7878 ramonn@br.ibm.com