This patchset breaks the tests. The first of the 12 failed tests is pasted below: ====================================================================== ERROR: test_storagepool (unittest.loader.ModuleImportFailure) ---------------------------------------------------------------------- ImportError: Failed to import test module: test_storagepool Traceback (most recent call last): File "/usr/lib64/python2.7/unittest/loader.py", line 252, in _find_tests module = self._get_module_from_name(name) File "/usr/lib64/python2.7/unittest/loader.py", line 230, in _get_module_from_name __import__(name) File "/home/vianac/LTC/kimchi/tests/test_storagepool.py", line 24, in <module> from kimchi.model.libvirtstoragepool import StoragePoolDef File "/home/vianac/LTC/kimchi/src/kimchi/model/libvirtstoragepool.py", line 26, in <module> from kimchi.exception import InvalidParameter, OperationFailed, TimeoutExpired File "/home/vianac/LTC/kimchi/src/kimchi/exception.py", line 25, in <module> from kimchi.template import get_lang, validate_language File "/home/vianac/LTC/kimchi/src/kimchi/template.py", line 25, in <module> from kimchi.config import paths File "/home/vianac/LTC/kimchi/src/kimchi/config.py", line 29, in <module> from kimchi.featuretests import FeatureTests File "/home/vianac/LTC/kimchi/src/kimchi/featuretests.py", line 33, in <module> from kimchi.utils import kimchi_log File "/home/vianac/LTC/kimchi/src/kimchi/utils.py", line 35, in <module> from kimchi.asynctask import AsyncTask File "/home/vianac/LTC/kimchi/src/kimchi/asynctask.py", line 25, in <module> from kimchi.exception import OperationFailed ImportError: cannot import name OperationFailed On 24-04-2014 14:19, shaohef@linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>
V7 -> V8 add a feature test to probe libvirt support metadata. add namespace for manully metadata.
V6 -> V7: After V6 rebase, still find one error code "KCHVM0029E" does not change.
V5 -> V6: rebase
V4 -> V5: it is wrong to call dom.isPersistent in V4, fix it.
V3 -> V4: work around if libvirt do not support metadata API well.
V2 -> V3: move the virDomain.metadata and virDomain.setMetadata to model/utils.py add testcase
V1 -> V2: libvirt also support virDomain.metadata and virDomain.setMetadata two api. use virDomain.metadata to get the user and group. use virDomain.setMetadata to set the user and group.
ShaoHe Feng (7): Add two function to set and get domain xml metadata bug fix: get user and group when vm is living. update test case to set/get user and group when VM is running write the template OS info to vm metadata bug fix: call a method should be followed by "()" add method to test libvirt api are available manually manage the metadata element
src/kimchi/config.py.in | 14 ++++++- src/kimchi/featuretests.py | 44 ++++++++++++++++++- src/kimchi/i18n.py | 1 + src/kimchi/model/utils.py | 97 ++++++++++++++++++++++++++++++++++++++++++ src/kimchi/model/vms.py | 102 ++++++++++++++++++++++++++++----------------- tests/test_model.py | 13 ++++++ 6 files changed, 229 insertions(+), 42 deletions(-)