Re: [Kimchi-devel] About the author information in Kimchi source code
On 02/25/2014 05:51 AM, Shu Ming wrote:
Hi,
As you have seen, we have author information in Kimchi source code to
specially honour the writer of the original source files and the
succeeding writers with substantial change. Unfortunately, I found the
authors in some files were updated without any substantial change. One
recent example about this is "src/kimchi/model/debugreports.py", the
author was changed to "Aline Manera" and the original author was gone.
And this change was introduced by "refactor model: Create a separated
model for debug report resource" that got a new file "debugreports.py"
split from another huge file without much change. I don't think this
split was deserved to change the author in the new file. Then, how do we
define what is "substantial change". I would say it is a new feature
changing the file with more than 1/3 of the total lines of code. It is a
not necessary a hard rule, but it is obvious that code split should not
be deserved to have a new author for the file.
Sorry, Ming, about that.
I created the license header on model/__init__.py and used it in all new
files I created for
refactoring model task.
My intention was not get credits from a work I didn't do.
And if you see in the former model.py (commit
a0a4dc0f949ed664076b5c47184d2b086d6de942) only
Adam Litke is listed as the author so, from what you wrote above, I
should keep him as the author
for *all* files created during refactor model.
**But** everyone knows everyone had contributed to model.py as well for
any other file in Kimchi
source repository.
So I am wondering why to have the name listed there became so important
right now.
You don't need to have your name listed there to get credits or honor
for a work you did.
git log is there to show all the contributions, the same for github
(https://github.com/kimchi-project/kimchi/graphs/contributors)
About the issue you mentioned, I was more concerned about getting the
refactor model done
than check line by line to identify who had written it.
We also have the AUTHORS file which list everyone as contributors to Kimchi.
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel