Re: [Kimchi-devel] [PATCH] [Kimchi 0/2] s390x architecture based changes
There is make check-local issues in the patch set:
make[3]: Entering directory
'/home/danielhb/kimchi/wok_all_plugins/src/wok/plugins/kimchi'
contrib/check_i18n.py ./i18n.py
Checking for invalid i18n string...
Checking for invalid i18n string successfully
/bin/pep8 --version
1.6.2
/bin/pep8 --filename '*.py,*.py.in'
--exclude="*config.py,*i18n.py,*tests/test_config.py" .
./isoinfo.py:399:8: E111 indentation is not a multiple of four
./isoinfo.py:404:8: E111 indentation is not a multiple of four
./isoinfo.py:404:21: E225 missing whitespace around operator
Apart from that I have a design question/comment in patch 2/2 too.
Daniel
On 08/09/2016 05:53 AM, archus(a)linux.vnet.ibm.com wrote:
From: Archana Singh <archus(a)linux.vnet.ibm.com>
1) On s390x machine, guestfs is not supported, hence made the change
in imageinfo.py to return unknown as distro and version on import error
of guestfs.
2) On s390x machine, scan cannot use El Torito boot specification.
Hence for now set bootable as True till we don't get the way to scan
on s390x.
Archana Singh (2):
Modified code, to return distro and version as unknown, if guestfs
import failed.
s390x based architecture changes.
imageinfo.py | 10 ++++++----
isoinfo.py | 10 ++++++++++
2 files changed, 16 insertions(+), 4 deletions(-)