1:27 p.m.
On 03/07/2014 03:13 PM, Aline Manera wrote:
It will not work in most of cases.
1. The default network and storage pool is usually created by libvirt
with the default values.
So an kimchi user will face the same issue while running kimchi on
nested virtualization.
I.e, there is not way to fix it. Just warning the user about the
problem.
2. This issue is in some way related to
https://github.com/kimchi-project/kimchi/issues/265
And why should not the user delete default network/storage pool?
This limitation should be impose to user when a network/storage
pool is used by a template or vm.
Otherwise, the user can remove it.
Usually the default network/storage pool is created by libvirt.
But some time ago, we identified it did not happen in some distros.
And as the Kimchi default configuration for templates is pointing
to those resources we decided to
create them manually on kimchi code to avoid problems while using
the templates.
So my proposal is: let's revisit all the supported distros and
check if libvirt creates default
network/storage pool by default, and if so remove this code from
kimchi.
Then default network/storage pool will have the same behavior from
other networks/storage pools.
So when starting kimchi we just need to make sure the default
network/storage pool are active.
And activate them if needed.
For nested virtualization, the default network will fail to activate as
the address is already in use.
In this case, we can get the properly error and automatically edit the
default network for the user to get an unused address.
So the steps to close issue #302 are:
1) Check if libvirt creates the default network/storage pool by default
1.1) If so, remove this code from kimchi code
2) On Kimchi start up, make sure default network/storage pool are active.
2.1) If network activate fails /because/ of the address is already
in use, kimchi automatically update the network address and start it.
On 03/07/2014 06:52 AM, shaohef(a)linux.vnet.ibm.com wrote:
> From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
>
> let 'create' attr of networks model to create the default network
>
> ShaoHe Feng (3):
> move _default_network_check from top model to networks model
> add a new function to get an available network address
> Issue #302: let 'create' attr of networks model to create default
> network
>
> src/kimchi/model/model.py | 35 ---------------------------------
> src/kimchi/model/networks.py | 46
> +++++++++++++++++++++++++++++++++++++-------
> src/kimchi/network.py | 7 +++++--
> 3 files changed, 44 insertions(+), 44 deletions(-)
>
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel