This patch will redirect to the Hosts tab, right? Shouldn't the Guests tab be the default "homepage" of Kimchi? Aline and I were discussing this some weeks ago. By default, when an user access Kimchi (http://<hostname>:8000) the homepage is the Host tab, but I remember in the past a discussion to make Guests as default homepage. IMO, Guests should be the default homepage just because the main goal of Kimchi is be an easier management tool for virtual machines (KVM), not the host! The patch is correct and it's solving the problem (a.k.a. Reviewed-by: Paulo Vital <pvital@linux.vnet.ibm.com>), but I think the real problem here is other: make Guest the default homepage in any situation. Best regards, -- Paulo Ricardo Paz Vital <pvital@linux.vnet.ibm.com> IBM Linux Technology Center On Fri, 2014-04-25 at 17:56 +0800, Hongliang Wang wrote:
It will lead user to a wrong "home page" in error.html. Correct it.
Signed-off-by: Hongliang Wang <hlwang@linux.vnet.ibm.com> --- ui/pages/error.html.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/pages/error.html.tmpl b/ui/pages/error.html.tmpl index 1336492..8d50231 100644 --- a/ui/pages/error.html.tmpl +++ b/ui/pages/error.html.tmpl @@ -63,7 +63,7 @@ </div> #end if <div class="error-msg"> - <a id="btn-homepage" class="btn-normal" href="/#guests">$_("Go to Homepage") ></a> + <a id="btn-homepage" class="btn-normal" href="/">$_("Go to Homepage") ></a> </div> </body> </html>