12:04 a.m.
This patch set changes the way Kimchi loads Help pages of the tabs of
the plugins.
It also changes the Sample plugin, in order to demonstrate and show
properly how to configure the a Help page
V5:
- removed do_substituion. Use kimchi.config.PluginPaths
- make changes proposed by Aline in kimchi.main.js
Rodrigo Trujillo (2):
Fix problems to open plugin's help pages
Changes in sample plugin to fix and improve help
plugins/sample/sample.conf.in | 5 ++
plugins/sample/ui/config/tab-ext.xml | 11 ++++-
plugins/sample/ui/pages/Makefile.am | 2 +-
.../sample/ui/pages/help/en_US/sample-tab1.html | 1 +
.../sample/ui/pages/help/en_US/sample-tab2.html | 1 +
plugins/sample/ui/pages/sample-tab1.html.tmpl | 30 ++++++++++++
plugins/sample/ui/pages/sample-tab2.html.tmpl | 30 ++++++++++++
plugins/sample/ui/pages/tab.html.tmpl | 30 ------------
ui/js/src/kimchi.main.js | 53 ++++++++++++++++------
9 files changed, 116 insertions(+), 47 deletions(-)
create mode 100644 plugins/sample/ui/pages/help/en_US/sample-tab1.html
create mode 100644 plugins/sample/ui/pages/help/en_US/sample-tab2.html
create mode 100644 plugins/sample/ui/pages/sample-tab1.html.tmpl
create mode 100644 plugins/sample/ui/pages/sample-tab2.html.tmpl
delete mode 100644 plugins/sample/ui/pages/tab.html.tmpl
--
1.9.3
12:04 a.m.
New subject: [PATCH 1/2 V5] Fix problems to open plugin's help pages
Kimchi is currently not able to configure and open help pages of any
plugin tab. This patch fixes this problem and removes the HELP button
if any Kimchi tab or plugin tab do not have a help configured properly
for the language being used.
(eg. if plugins/<tab_html>/help/<lang>/<tab_html>.html does not exist,
then the help button is disabled).
A help page for a plugin tab follow same Kimchi system:
- html help file should have the same name of plugin html tab file;
- html files should be placed in plugin's " ui/pages/help/<LANG> "
path;
- plugin should add following lines to <PLUGIN_NAME>.conf:
* [/help]
* tools.staticdir.on = True
* tools.nocache.on = True
* tools.staticdir.dir = '<HELP PAGE DIRECTORY>'
Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com>
---
ui/js/src/kimchi.main.js | 53 +++++++++++++++++++++++++++++++++++-------------
1 file changed, 39 insertions(+), 14 deletions(-)
diff --git a/ui/js/src/kimchi.main.js b/ui/js/src/kimchi.main.js
index a8ae42a..1424827 100644
--- a/ui/js/src/kimchi.main.js
+++ b/ui/js/src/kimchi.main.js
@@ -38,11 +38,14 @@ kimchi.main = function() {
var path = tab['path'];
var mode = tab['mode'];
if (mode != 'none') {
+ var helpPath = kimchi.checkHelpFile(path);
+ var disableHelp = (helpPath.length == 0 ? "disableHelp" :
helpPath);
tabsHtml.push(
'<li>',
- '<a class="item" href="', path,
'">',
+ '<a class="item ', disableHelp,'"
href="', path, '">',
title,
'</a>',
+ '<input id="helpPathId"
name="helpPath" value="' + helpPath + '"
type="hidden"/>',
'</li>'
);
}
@@ -161,7 +164,15 @@ kimchi.main = function() {
$('#nav-menu a').removeClass('current');
$(tab).addClass('current');
$(tab).focus();
-
+ // Disable Help button according to selected tab
+ if ($(tab).hasClass("disableHelp")) {
+ $('#btn-help').css('cursor', "not-allowed");
+ $('#btn-help').off("click");
+ }
+ else {
+ $('#btn-help').css('cursor', "pointer");
+ $('#btn-help').on("click", kimchi.openHelp);
+ }
// Load page content.
loadPage(url);
};
@@ -261,7 +272,7 @@ kimchi.main = function() {
});
// Set handler for help button
- $('#btn-help').on('click', kimchi.getHelp);
+ $('#btn-help').on('click', kimchi.openHelp);
// Set handler to peers drop down
$('#peers').on('click', function() {
@@ -328,15 +339,29 @@ kimchi.main = function() {
});
};
-kimchi.getHelp = function(e) {
- var url = window.location.hash;
- var lang = kimchi.lang.get();
- url = url.replace("#tabs", "/help/" + lang);
- if (url == "/help" + lang)
- url = url + "/index.html"
- else
- url = url + ".html";
-
- window.open(url, "Kimchi Help");
- e.preventDefault();
+
+kimchi.checkHelpFile = function(path) {
+ var lang = kimchi.lang.get();
+ var url = ""
+ // Find help page path according to tab name
+ if (/^tabs/.test(path))
+ url = path.replace("tabs", "/help/" + lang);
+ else if (/^plugins/.test(path))
+ url = path.slice(0, path.lastIndexOf('/')) + "/help/" + lang +
path.slice(path.lastIndexOf('/'));
+ // Checking if help page exist.
+ $.ajax({
+ url: url,
+ async: false,
+ error: function() { url = ""; },
+ success: function() { }
+ });
+ return url;
+};
+
+
+kimchi.openHelp = function(e) {
+ var tab = $('#nav-menu a.current');
+ var url = $(tab).parent().find("input[name='helpPath']").val();
+ window.open(url, "Kimchi Help");
+ e.preventDefault();
};
--
1.9.3
12:04 a.m.
New subject: [PATCH 2/2 V5] Changes in sample plugin to fix and improve help
This patch set changes the Sample plugin, adding a new tab, modifying
naming and other elements in order to show help pages properly.
Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com>
---
plugins/sample/sample.conf.in | 5 ++++
plugins/sample/ui/config/tab-ext.xml | 11 ++++++--
plugins/sample/ui/pages/Makefile.am | 2 +-
.../sample/ui/pages/help/en_US/sample-tab1.html | 1 +
.../sample/ui/pages/help/en_US/sample-tab2.html | 1 +
plugins/sample/ui/pages/sample-tab1.html.tmpl | 30 ++++++++++++++++++++++
plugins/sample/ui/pages/sample-tab2.html.tmpl | 30 ++++++++++++++++++++++
plugins/sample/ui/pages/tab.html.tmpl | 30 ----------------------
8 files changed, 77 insertions(+), 33 deletions(-)
create mode 100644 plugins/sample/ui/pages/help/en_US/sample-tab1.html
create mode 100644 plugins/sample/ui/pages/help/en_US/sample-tab2.html
create mode 100644 plugins/sample/ui/pages/sample-tab1.html.tmpl
create mode 100644 plugins/sample/ui/pages/sample-tab2.html.tmpl
delete mode 100644 plugins/sample/ui/pages/tab.html.tmpl
diff --git a/plugins/sample/sample.conf.in b/plugins/sample/sample.conf.in
index cf42467..ac7e27f 100644
--- a/plugins/sample/sample.conf.in
+++ b/plugins/sample/sample.conf.in
@@ -20,3 +20,8 @@ tools.kimchiauth.on = True
[/circles]
tools.kimchiauth.on = True
+
+[/help]
+tools.staticdir.on = True
+tools.nocache.on = True
+tools.staticdir.dir = kimchi.config.PluginPaths('sample').ui_dir +
'/pages/help'
diff --git a/plugins/sample/ui/config/tab-ext.xml b/plugins/sample/ui/config/tab-ext.xml
index a1fb1c2..aff0d14 100644
--- a/plugins/sample/ui/config/tab-ext.xml
+++ b/plugins/sample/ui/config/tab-ext.xml
@@ -4,7 +4,14 @@
<access role="admin" mode="admin"/>
<access role="user" mode="none"/>
- <title>SampleTab</title>
- <path>plugins/sample/tab.html</path>
+ <title>SampleTab 1</title>
+ <path>plugins/sample/sample-tab1.html</path>
+ </tab>
+ <tab>
+ <access role="admin" mode="admin"/>
+ <access role="user" mode="none"/>
+
+ <title>SampleTab 2</title>
+ <path>plugins/sample/sample-tab2.html</path>
</tab>
</tabs-ext>
diff --git a/plugins/sample/ui/pages/Makefile.am b/plugins/sample/ui/pages/Makefile.am
index ca22446..3da95a2 100644
--- a/plugins/sample/ui/pages/Makefile.am
+++ b/plugins/sample/ui/pages/Makefile.am
@@ -17,4 +17,4 @@
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-EXTRA_DIST = i18n.json.tmpl tab.html.tmpl
+EXTRA_DIST = i18n.json.tmpl sample-tab1.html.tmpl sample-tab2.html.tmpl
diff --git a/plugins/sample/ui/pages/help/en_US/sample-tab1.html
b/plugins/sample/ui/pages/help/en_US/sample-tab1.html
new file mode 100644
index 0000000..70aa1c0
--- /dev/null
+++ b/plugins/sample/ui/pages/help/en_US/sample-tab1.html
@@ -0,0 +1 @@
+Help page for TAB 1 of Kimchi's Sample plugin.
diff --git a/plugins/sample/ui/pages/help/en_US/sample-tab2.html
b/plugins/sample/ui/pages/help/en_US/sample-tab2.html
new file mode 100644
index 0000000..367318f
--- /dev/null
+++ b/plugins/sample/ui/pages/help/en_US/sample-tab2.html
@@ -0,0 +1 @@
+Help page for TAB 2 of Kimchi's Sample plugin.
diff --git a/plugins/sample/ui/pages/sample-tab1.html.tmpl
b/plugins/sample/ui/pages/sample-tab1.html.tmpl
new file mode 100644
index 0000000..4354d81
--- /dev/null
+++ b/plugins/sample/ui/pages/sample-tab1.html.tmpl
@@ -0,0 +1,30 @@
+#*
+ * Project Kimchi
+ *
+ * Copyright IBM, Corp. 2014
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *#
+#unicode UTF-8
+<!DOCTYPE html>
+<html>
+<script type="text/javascript"
src="plugins/sample/js/util.js"></script>
+<body>
+ <div id="samplebody"/>
+</body>
+<script>
+ sample.description(function(r){
+ \$("#samplebody").html("name: " + r.name + " version:
" + r.version);
+ });
+</script>
+</html>
diff --git a/plugins/sample/ui/pages/sample-tab2.html.tmpl
b/plugins/sample/ui/pages/sample-tab2.html.tmpl
new file mode 100644
index 0000000..4354d81
--- /dev/null
+++ b/plugins/sample/ui/pages/sample-tab2.html.tmpl
@@ -0,0 +1,30 @@
+#*
+ * Project Kimchi
+ *
+ * Copyright IBM, Corp. 2014
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *#
+#unicode UTF-8
+<!DOCTYPE html>
+<html>
+<script type="text/javascript"
src="plugins/sample/js/util.js"></script>
+<body>
+ <div id="samplebody"/>
+</body>
+<script>
+ sample.description(function(r){
+ \$("#samplebody").html("name: " + r.name + " version:
" + r.version);
+ });
+</script>
+</html>
diff --git a/plugins/sample/ui/pages/tab.html.tmpl
b/plugins/sample/ui/pages/tab.html.tmpl
deleted file mode 100644
index 4354d81..0000000
--- a/plugins/sample/ui/pages/tab.html.tmpl
+++ /dev/null
@@ -1,30 +0,0 @@
-#*
- * Project Kimchi
- *
- * Copyright IBM, Corp. 2014
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *#
-#unicode UTF-8
-<!DOCTYPE html>
-<html>
-<script type="text/javascript"
src="plugins/sample/js/util.js"></script>
-<body>
- <div id="samplebody"/>
-</body>
-<script>
- sample.description(function(r){
- \$("#samplebody").html("name: " + r.name + " version:
" + r.version);
- });
-</script>
-</html>
--
1.9.3
2:09 a.m.
Tested-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Help of original tabs can be opened.
Help of plugin tabs can be opened.
If there is no help file, the mouse icon becomes disabled when move over
the help menu item.
on 2014/10/15 13:04, Rodrigo Trujillo wrote:
This patch set changes the way Kimchi loads Help pages of the tabs
of
the plugins.
It also changes the Sample plugin, in order to demonstrate and show
properly how to configure the a Help page
V5:
- removed do_substituion. Use kimchi.config.PluginPaths
- make changes proposed by Aline in kimchi.main.js
Rodrigo Trujillo (2):
Fix problems to open plugin's help pages
Changes in sample plugin to fix and improve help
plugins/sample/sample.conf.in | 5 ++
plugins/sample/ui/config/tab-ext.xml | 11 ++++-
plugins/sample/ui/pages/Makefile.am | 2 +-
.../sample/ui/pages/help/en_US/sample-tab1.html | 1 +
.../sample/ui/pages/help/en_US/sample-tab2.html | 1 +
plugins/sample/ui/pages/sample-tab1.html.tmpl | 30 ++++++++++++
plugins/sample/ui/pages/sample-tab2.html.tmpl | 30 ++++++++++++
plugins/sample/ui/pages/tab.html.tmpl | 30 ------------
ui/js/src/kimchi.main.js | 53 ++++++++++++++++------
9 files changed, 116 insertions(+), 47 deletions(-)
create mode 100644 plugins/sample/ui/pages/help/en_US/sample-tab1.html
create mode 100644 plugins/sample/ui/pages/help/en_US/sample-tab2.html
create mode 100644 plugins/sample/ui/pages/sample-tab1.html.tmpl
create mode 100644 plugins/sample/ui/pages/sample-tab2.html.tmpl
delete mode 100644 plugins/sample/ui/pages/tab.html.tmpl
--
Zhou Zheng Sheng / 周征晟
E-mail: zhshzhou(a)linux.vnet.ibm.com
Telephone: 86-10-82454397
3480
days inactive
3480
days old
4 comments
3 participants
participants (3)
-
Aline Manera -
Rodrigo Trujillo -
Zhou Zheng Sheng