[RFC] All plug-ins: accessibility changes in wok.message
Hi everyone, There is an accessibility issue in WoK concerning all messages launched by wok.message method: https://github.com/kimchi-project/wok/issues/79 Problem is that the message may disappear and the user might lose information. If we increase the timeout too much then the message becomes an annoyance. My proposal is to make *all* messages closeable by user interaction. This is made at this moment by the 'closeable' flag in the method: wok.message = function(msg, level, node, closeable, onclick) What I want to do is to get rid of the 'closeable' flag, together with the code that makes the message fade with timeout. After that, all WoK messages from all plug-ins would have the "X" icon to be closed manually. This will require changes in all plug-ins that instantiate any wok.message.* method. I am willing to do those changes too. Thoughts?
On 17-05-2016 17:55, Daniel Henrique Barboza wrote:
Hi everyone,
There is an accessibility issue in WoK concerning all messages launched by wok.message method:
https://github.com/kimchi-project/wok/issues/79
Problem is that the message may disappear and the user might lose information. If we increase the timeout too much then the message becomes an annoyance.
My proposal is to make *all* messages closeable by user interaction. This is made at this moment by the 'closeable' flag in the method:
wok.message = function(msg, level, node, closeable, onclick)
What I want to do is to get rid of the 'closeable' flag, together with the code that makes the message fade with timeout. After that, all WoK messages from all plug-ins would have the "X" icon to be closed manually.
This will require changes in all plug-ins that instantiate any wok.message.* method. I am willing to do those changes too.
Thoughts? _______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
Agreed! -- Lucio Correia Software Engineer IBM LTC Brazil
Hi Daniel, This is a great idea and it has been discussed in the past. Everyone was in agreement to have an 'x' in the top right-hand corner in order for the messages to be closeable. In an attempt to implement this, I have come across some issues that Samuel had some ideas on but unfortunately has not had time for as there were other higher priorities. The issue was that when closing the error message, in some cases, it would close the parent panel rather than just the error message. I believe this is a big enough issue that it needs to be fixed first. Thanks -Socorro On 05/17/2016 01:55 PM, Daniel Henrique Barboza wrote:
Hi everyone,
There is an accessibility issue in WoK concerning all messages launched by wok.message method:
https://github.com/kimchi-project/wok/issues/79
Problem is that the message may disappear and the user might lose information. If we increase the timeout too much then the message becomes an annoyance.
My proposal is to make *all* messages closeable by user interaction. This is made at this moment by the 'closeable' flag in the method:
wok.message = function(msg, level, node, closeable, onclick)
What I want to do is to get rid of the 'closeable' flag, together with the code that makes the message fade with timeout. After that, all WoK messages from all plug-ins would have the "X" icon to be closed manually.
This will require changes in all plug-ins that instantiate any wok.message.* method. I am willing to do those changes too.
Thoughts? _______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
On 05/18/2016 11:18 AM, Socorro Stoppler wrote:
Hi Daniel,
This is a great idea and it has been discussed in the past. Everyone was in agreement to have an 'x' in the top right-hand corner in order for the messages to be closeable. In an attempt to implement this, I have come across some issues that Samuel had some ideas on but unfortunately has not had time for as there were other higher priorities.
The issue was that when closing the error message, in some cases, it would close the parent panel rather than just the error message. I believe this is a big enough issue that it needs to be fixed first.
I completely agree. I have found this exact bug in the Add Network modal from Kimchi, the warning message when you have Network Manager enabled. If you close this warning message the whole modal closes. I will not take any action with WoK until this bug is sorted out. I'll investigate it to see if I found out why but I really appreciate if any UI expert can look into it too. Daniel
Thanks -Socorro
On 05/17/2016 01:55 PM, Daniel Henrique Barboza wrote:
Hi everyone,
There is an accessibility issue in WoK concerning all messages launched by wok.message method:
https://github.com/kimchi-project/wok/issues/79
Problem is that the message may disappear and the user might lose information. If we increase the timeout too much then the message becomes an annoyance.
My proposal is to make *all* messages closeable by user interaction. This is made at this moment by the 'closeable' flag in the method:
wok.message = function(msg, level, node, closeable, onclick)
What I want to do is to get rid of the 'closeable' flag, together with the code that makes the message fade with timeout. After that, all WoK messages from all plug-ins would have the "X" icon to be closed manually.
This will require changes in all plug-ins that instantiate any wok.message.* method. I am willing to do those changes too.
Thoughts? _______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
participants (3)
-
Daniel Henrique Barboza -
Lucio Correia -
Socorro Stoppler