[PATCH] [Kimchi] Bugfix 778: Add volume freezes screen
This patch fixes the screen freezing when adding a storage volume via upload file. The problem was that the item being retrieved from the array was the wrong one since the path has changed. Socorro Stoppler (1): Fix screen freezing when upload file for storage volume ui/js/src/kimchi.storage_main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.9.1
Signed-off-by: Socorro Stoppler <socorro@linux.vnet.ibm.com> --- ui/js/src/kimchi.storage_main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js index 29ee365..cd24f10 100644 --- a/ui/js/src/kimchi.storage_main.js +++ b/ui/js/src/kimchi.storage_main.js @@ -450,7 +450,7 @@ kimchi.storage_main = function() { }; var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); var progress = extractProgressData(result['message']); var size = progress['size']; @@ -467,7 +467,7 @@ kimchi.storage_main = function() { wok.topic('kimchi/volumeTransferFinished').subscribe(function(result) { var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); var volumeBox = $('#volume' + poolName + ' [data-volume-name="' + volumeName + '"]'); $('.volume-progress', volumeBox).addClass('hidden'); -- 1.9.1
Socorro, I have just tested the patch in Firefox. I still see the problem ... screen becomes white and freezes. Am I missing some other patch ? Because line numbers are different from what is upstream Rodrigo Trujillo On 12/09/2015 10:49 PM, Socorro Stoppler wrote:
Signed-off-by: Socorro Stoppler <socorro@linux.vnet.ibm.com> --- ui/js/src/kimchi.storage_main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js index 29ee365..cd24f10 100644 --- a/ui/js/src/kimchi.storage_main.js +++ b/ui/js/src/kimchi.storage_main.js @@ -450,7 +450,7 @@ kimchi.storage_main = function() { };
var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); var progress = extractProgressData(result['message']); var size = progress['size']; @@ -467,7 +467,7 @@ kimchi.storage_main = function() {
wok.topic('kimchi/volumeTransferFinished').subscribe(function(result) { var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); var volumeBox = $('#volume' + poolName + ' [data-volume-name="' + volumeName + '"]'); $('.volume-progress', volumeBox).addClass('hidden');
Please ignore this patch. Resending a new one (should've just done an amend, but I did a reset so I lost my commit). Thanks. On 12/10/2015 03:54 AM, Rodrigo Trujillo wrote:
Socorro, I have just tested the patch in Firefox. I still see the problem ... screen becomes white and freezes. Am I missing some other patch ? Because line numbers are different from what is upstream
Rodrigo Trujillo
On 12/09/2015 10:49 PM, Socorro Stoppler wrote:
Signed-off-by: Socorro Stoppler <socorro@linux.vnet.ibm.com> --- ui/js/src/kimchi.storage_main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js index 29ee365..cd24f10 100644 --- a/ui/js/src/kimchi.storage_main.js +++ b/ui/js/src/kimchi.storage_main.js @@ -450,7 +450,7 @@ kimchi.storage_main = function() { };
var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); var progress = extractProgressData(result['message']); var size = progress['size']; @@ -467,7 +467,7 @@ kimchi.storage_main = function() {
wok.topic('kimchi/volumeTransferFinished').subscribe(function(result) { var uriElements = result.target_uri.split('/'); - var poolName = uriElements[2]; + var poolName = uriElements[4]; var volumeName = uriElements.pop(); var volumeBox = $('#volume' + poolName + ' [data-volume-name="' + volumeName + '"]'); $('.volume-progress', volumeBox).addClass('hidden');
participants (2)
-
Rodrigo Trujillo -
Socorro Stoppler