On 01/13/2014 05:43 AM, Hongliang Wang wrote:

On 01/10/2014 10:13 PM, Aline Manera wrote:

...

Some comments:

1) Make sure to have Makefile.am files updated as you are adding new files

ACK

...

2) Always use 4 spaces for indentation

ACK

...

3) About API: - For federation: I suggest to use /peers instead of /hosts In addition to list, add, remove actions we also need a discover function to find the peers automatically for the user. - For host repositories: from the previous backend patches sent o former mail list, it should be /host/repositories instead of /repositories

ACK

...

4) About UI: I prefer to have the "Federation" section listed like the other ones. So, when opening the "Federation" section, we display a table (like those used) with peers information and actions buttons. Peers are not in a subset of host, so they are not put in a "Federation" Section like those used.

What's more, we need a trade-off here.

Federated peers are in the same level of localhost, that means peers including current host are all within a tree structure with same level:

- Federation - localhost - Peer 1 - Peer 2 - ...

When clicking one of the federated peers, user will be guided to the corresponding page of that peer.

This leads to 2 types of design:

1) Flatten

====================================== Kimchi Logo _____________________________________________________________

Peers | Guests | Templates | Storage | Network ___/\_________________________________________________________

localhost 0.0.0.0 1 VMs, 2 Templates, 3 Pools

Peer 1 9.1.2.1 Go > Peer 2 9.1.2.2 Go > Peer 3 9.1.2.3 Go > ======================================

2) Hierarchy

========================================== Kimchi Logo ___________________________________________________________________ (Floating Menu) | Federated Peers | Host | Guests | Templates | Storage | Network - localhost |___/\_____________________________________________ - Peer 1 > | - Peer 2 > | - Peer 3 > | ==========================================

The difference between the 2 types is usage frequency of federated peers. If the user jumps to other peers frequently, Option 1 is better; otherwise, the user rarely jumps to other peers, Option 2 is better. In this patch, user is supposed to rarely jump to other peers.

I'd say I prefer the option 2. That way we can have the host info in a tab and all the peers in a separated one.

Welcome more discussions.

...

On 12/30/2013 05:57 AM, Hongliang Wang wrote:

...

Added federated hosts; Added host repository management.

There is a bug in kimchi.widget.Grid widget: when there are more than one Grid instances in the page, column resizing function will work incorrectly. I'll send another patch to fix it.

Hongliang Wang (2): Federated Hosts Management Host Repositories Management UI

src/kimchi/model.py | 1 + ui/css/theme-default/host-add.css | 29 +++++++ ui/css/theme-default/host-edit.css | 29 +++++++ ui/css/theme-default/host.css | 80 +++++++++++++++--- ui/css/theme-default/hosts.css | 24 ++++++ ui/css/theme-default/repository-edit.css | 29 +++++++ ui/css/theme-default/window.css | 6 +- ui/images/theme-default/host-icon-sprite.png | Bin 1034 -> 1163 bytes ui/js/src/kimchi.api.js | 110 +++++++++++++++++++++++++ ui/js/src/kimchi.grid.js | 2 +- ui/js/src/kimchi.host.js | 93 +++++++++++++++++++++ ui/js/src/kimchi.host_add_main.js | 62 ++++++++++++++ ui/js/src/kimchi.host_edit_main.js | 62 ++++++++++++++ ui/js/src/kimchi.hosts.js | 116 +++++++++++++++++++++++++++ ui/js/src/kimchi.repository_edit_main.js | 62 ++++++++++++++ ui/pages/guest-add.html.tmpl | 2 +- ui/pages/guest-edit.html.tmpl | 2 +- ui/pages/host-add.html.tmpl | 66 +++++++++++++++ ui/pages/host-edit.html.tmpl | 66 +++++++++++++++ ui/pages/hosts.html.tmpl | 41 ++++++++++ ui/pages/i18n.html.tmpl | 16 ++++ ui/pages/login-window.html.tmpl | 2 +- ui/pages/report-add.html.tmpl | 2 +- ui/pages/repository-edit.html.tmpl | 66 +++++++++++++++ ui/pages/storagepool-add.html.tmpl | 2 +- ui/pages/tabs/host.html.tmpl | 40 ++++++++- ui/pages/template-add.html.tmpl | 2 +- ui/pages/template-edit.html.tmpl | 2 +- 28 files changed, 989 insertions(+), 25 deletions(-) create mode 100644 ui/css/theme-default/host-add.css create mode 100644 ui/css/theme-default/host-edit.css create mode 100644 ui/css/theme-default/hosts.css create mode 100644 ui/css/theme-default/repository-edit.css create mode 100644 ui/js/src/kimchi.host_add_main.js create mode 100644 ui/js/src/kimchi.host_edit_main.js create mode 100644 ui/js/src/kimchi.hosts.js create mode 100644 ui/js/src/kimchi.repository_edit_main.js create mode 100644 ui/pages/host-add.html.tmpl create mode 100644 ui/pages/host-edit.html.tmpl create mode 100644 ui/pages/hosts.html.tmpl create mode 100644 ui/pages/repository-edit.html.tmpl