[PATCH] Bugfix: Log out from Administrator tab raises popup errors
This bug turns out to be caused by we change the login format from login-window to tranditional login format. After the logout, we can no longer and there is no need to update the pages and popup a login window. Now we redirect to login.html after logout. Signed-off-by: Wen Wang <wenwang@linux.vnet.ibm.com> --- ui/js/src/kimchi.main.js | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/js/src/kimchi.main.js b/ui/js/src/kimchi.main.js index 613ab41..ba54b26 100644 --- a/ui/js/src/kimchi.main.js +++ b/ui/js/src/kimchi.main.js @@ -239,7 +239,7 @@ kimchi.main = function() { // Perform logging out via Ajax request. $('#btn-logout').on('click', function() { kimchi.logout(function() { - updatePage(); + document.location.href = "login.html"; }, function(err) { kimchi.message.error(err.responseJSON.reason); }); -- 1.7.1
On 08/19/2014 04:22 AM, Wen Wang wrote:
This bug turns out to be caused by we change the login format from login-window to tranditional login format. After the logout, we can no longer and there is no need to update the pages and popup a login window. Now we redirect to login.html after logout.
Signed-off-by: Wen Wang <wenwang@linux.vnet.ibm.com> --- ui/js/src/kimchi.main.js | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ui/js/src/kimchi.main.js b/ui/js/src/kimchi.main.js index 613ab41..ba54b26 100644 --- a/ui/js/src/kimchi.main.js +++ b/ui/js/src/kimchi.main.js @@ -239,7 +239,7 @@ kimchi.main = function() { // Perform logging out via Ajax request. $('#btn-logout').on('click', function() { kimchi.logout(function() { - updatePage(); + document.location.href = "login.html";
Could we remove updatePage() function? Or is it still in use in somewhere else?
}, function(err) { kimchi.message.error(err.responseJSON.reason); });
On 19-08-2014 15:15, Aline Manera wrote:
Could we remove updatePage() function? Or is it still in use in somewhere else?
Apparently, it is: $ git grep updatePage ui/js/src/kimchi.main.js: var updatePage = function() { ui/js/src/kimchi.main.js: window.onhashchange = updatePage; ui/js/src/kimchi.main.js: updatePage(); ui/js/src/kimchi.main.js: updatePage(); One of those occurrences is the one that was removed in this patch, so there still seems to be two direct uses of that function.
exactly. On 8/20/2014 2:20 AM, Crístian Viana wrote:
On 19-08-2014 15:15, Aline Manera wrote:
Could we remove updatePage() function? Or is it still in use in somewhere else?
Apparently, it is:
$ git grep updatePage ui/js/src/kimchi.main.js: var updatePage = function() { ui/js/src/kimchi.main.js: window.onhashchange = updatePage; ui/js/src/kimchi.main.js: updatePage(); ui/js/src/kimchi.main.js: updatePage();
One of those occurrences is the one that was removed in this patch, so there still seems to be two direct uses of that function.
On 8/20/2014 2:15 AM, Aline Manera wrote:
On 08/19/2014 04:22 AM, Wen Wang wrote:
This bug turns out to be caused by we change the login format from login-window to tranditional login format. After the logout, we can no longer and there is no need to update the pages and popup a login window. Now we redirect to login.html after logout.
Signed-off-by: Wen Wang <wenwang@linux.vnet.ibm.com> --- ui/js/src/kimchi.main.js | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ui/js/src/kimchi.main.js b/ui/js/src/kimchi.main.js index 613ab41..ba54b26 100644 --- a/ui/js/src/kimchi.main.js +++ b/ui/js/src/kimchi.main.js @@ -239,7 +239,7 @@ kimchi.main = function() { // Perform logging out via Ajax request. $('#btn-logout').on('click', function() { kimchi.logout(function() { - updatePage(); + document.location.href = "login.html";
Could we remove updatePage() function? Or is it still in use in somewhere else?
No, we cannot, It's been used. [wangwen@oc3477250524 kimchi]$ git grep updatePage ui/js/src/kimchi.main.js: var updatePage = function() { ui/js/src/kimchi.main.js: window.onhashchange = updatePage; ui/js/src/kimchi.main.js: updatePage(); ui/js/src/kimchi.main.js: updatePage();
}, function(err) { kimchi.message.error(err.responseJSON.reason); });
participants (3)
-
Aline Manera -
Crístian Viana -
Wen Wang