[PATCH] Adds spice.html.tmpl to makefile.am
The file spice.html.tmpl is not being added to rpm packages because it was not added to Makefile.am. This patch fixed this problem. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com> --- ui/pages/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/pages/Makefile.am b/ui/pages/Makefile.am index 8d72398..9908376 100644 --- a/ui/pages/Makefile.am +++ b/ui/pages/Makefile.am @@ -35,4 +35,5 @@ dist_html_DATA = \ login-window.html.tmpl \ storagepool-add.html.tmpl \ report-add.html.tmpl \ + spice.html.tmpl \ $(NULL) -- 1.8.5.3
Reviewed-by: Crístian Viana Am 20-02-2014 15:18, schrieb Rodrigo Trujillo:
The file spice.html.tmpl is not being added to rpm packages because it was not added to Makefile.am. This patch fixed this problem.
Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com>
I know we were doing that for a while but listing file by file in Makefile.am is causing a lot of problems for us. Always one file is missed out of Makefile. So why do not we user $(wildcard <pattern>) as Cristian did for help/Makefile.am? That way we avoid changing the Makefile so often On 02/20/2014 03:18 PM, Rodrigo Trujillo wrote:
The file spice.html.tmpl is not being added to rpm packages because it was not added to Makefile.am. This patch fixed this problem.
Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com> --- ui/pages/Makefile.am | 1 + 1 file changed, 1 insertion(+)
diff --git a/ui/pages/Makefile.am b/ui/pages/Makefile.am index 8d72398..9908376 100644 --- a/ui/pages/Makefile.am +++ b/ui/pages/Makefile.am @@ -35,4 +35,5 @@ dist_html_DATA = \ login-window.html.tmpl \ storagepool-add.html.tmpl \ report-add.html.tmpl \ + spice.html.tmpl \ $(NULL)
Thats ok ! much better. Thanks On 02/20/2014 03:42 PM, Aline Manera wrote:
I know we were doing that for a while but listing file by file in Makefile.am is causing a lot of problems for us. Always one file is missed out of Makefile.
So why do not we user $(wildcard <pattern>) as Cristian did for help/Makefile.am? That way we avoid changing the Makefile so often
On 02/20/2014 03:18 PM, Rodrigo Trujillo wrote:
The file spice.html.tmpl is not being added to rpm packages because it was not added to Makefile.am. This patch fixed this problem.
Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo@linux.vnet.ibm.com> --- ui/pages/Makefile.am | 1 + 1 file changed, 1 insertion(+)
diff --git a/ui/pages/Makefile.am b/ui/pages/Makefile.am index 8d72398..9908376 100644 --- a/ui/pages/Makefile.am +++ b/ui/pages/Makefile.am @@ -35,4 +35,5 @@ dist_html_DATA = \ login-window.html.tmpl \ storagepool-add.html.tmpl \ report-add.html.tmpl \ + spice.html.tmpl \ $(NULL)
participants (3)
-
Aline Manera -
Crístian Viana -
Rodrigo Trujillo