Re: [Kimchi-devel] [project-kimchi][PATCH 0/3] NFS prevalidation

于 2013/12/17 20:10, lvroyce0210@gmail.com 写道:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
This patchset solves following problem: 1. libvirt uses local directory when nfs target path is not accessible, this patch denies this unaccessible path instead. 2. libvirt storage subsystem hang for a long period, with a quick checking, storage pool operation will not hang if pre-checked. 3. Future access control check will do in prevalidation, this prevents qemu manipulate storage pool of no read access to make early warning. Royce Lv (3): utils: Add a helper function to parse cmd result NFS prevalidation: try nfs path mount in feature test Integrate nfs path check before create nfs pool
src/kimchi/featuretests.py | 32 ++++++++++++++++++++++++++++++++ src/kimchi/model.py | 5 +++++ src/kimchi/utils.py | 7 +++++++ 3 files changed, 44 insertions(+)
Thanks for addressing this issue and I get a few questions about this patch: I) nfs server can be be reachable can be caused by different problems, ie. network, server &etc. For network proI blems, it may come back to life after down for a few seconds. So it is hard to predict when the nfs server will be down. I realized that put in featuretests.py will cause some confusion that
On 2013年12月18日 10:26, Shu Ming wrote: this is tested when kimchi started. In fact this will be validated just before storage pool created so the lease will be very small between create pool and validation. Will fix in next release.
II) I think feature test is a bit broken now and we get many junk messages in the screen when the Kimchi server is started. Really, We don't want more junk message in the screen.
-- project-kimchi mailing list <project-kimchi@googlegroups.com> https://groups.google.com/forum/#!forum/project-kimchi --- You received this message because you are subscribed to the Google Groups "project-kimchi" group. To unsubscribe from this group and stop receiving emails from it, send an email to project-kimchi+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
participants (1)
-
Royce Lv