Is this patch going to be applied with the bug fixes or in next release?
I'm asking because after the G.A I'll be adding the Storage Volumes "table
view" like the attached screenshots (minus the checkbox in the gallery view, it will
look like when you select a Template) so if we all agree in inverting the order, I would
update the widget with the inverse order with the other enhancements. I noticed that the
texts are not in bold in some screenshots and this is due a font rendering issue with
Firefox that I'm still investigating. The selectable volumes are among some older
mockups that Susan sent that are not in the Design Spec pdf.
volumes_kimchi.png is the current version on my desktop. If the font is different then it
is not Open Sans and that's why the texts are not bold.
I think both designs are ok but I don't see this widget as a table. Usually the table
headers are bold and not the table content.
Samuel
-----Original Message-----
From: kimchi-devel-bounces(a)ovirt.org [mailto:kimchi-devel-bounces@ovirt.org] On Behalf Of
Ramon Medeiros
Sent: quinta-feira, 10 de dezembro de 2015 13:36
To: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com>; kimchi-devel(a)ovirt.org
Subject: Re: [Kimchi-devel] [PATCH][Kimchi] Fix issue #774 - Invert keys and values in
storage volumes boxes
Reviewed-By: Ramon Medeiros <ramonn(a)br.ibm.com>
On 12/10/2015 01:34 PM, Rodrigo Trujillo wrote:
Move fields to the right position.
Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com>
---
ui/pages/storage.html.tmpl | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/pages/storage.html.tmpl b/ui/pages/storage.html.tmpl
index 9f2a978..d11f10c 100644
--- a/ui/pages/storage.html.tmpl
+++ b/ui/pages/storage.html.tmpl
@@ -161,20 +161,20 @@
</div>
<ul class="volume-data">
<li>
- <span class="value"
title="{format}">{format}</span>
<span
class="key">$_("Format")</span>
+ <span class="value"
+ title="{format}">{format}</span>
</li>
<li>
- <span class="value"
title="{type}">{type}</span>
<span
class="key">$_("Type")</span>
+ <span class="value"
title="{type}">{type}</span>
</li>
<li>
- <span class="value"
title="{allocation}">{allocation}</span>
<span
class="key">$_("Allocation")</span>
+ <span class="value"
+ title="{allocation}">{allocation}</span>
</li>
<li>
- <span class="value"
title="{capacity}">{capacity}</span>
<span
class="key">$_("Capacity")</span>
+ <span class="value"
+ title="{capacity}">{capacity}</span>
</li>
</ul>
</div>
@@ -195,4 +195,4 @@
</script>
<div id="modalWindow" class="modal fade storage-modal"
tabindex="-1" role="dialog"
aria-labelledby="storageModalLabel" aria-hidden="true">
</div>
</body>
-</html>
\ No newline at end of file
+</html>
--
Ramon Nunes Medeiros
Kimchi Developer
Linux Technology Center Brazil
IBM Systems & Technology Group
Phone : +55 19 2132 7878
ramonn(a)br.ibm.com
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel