[PATCH 0/2] Updating Fedora remote ISO information
From: Paulo Vital <pvital@linux.vnet.ibm.com> Patch set that fixes worng information about Fedora 21 remote ISO and adds a new option to Fedora 22. Paulo Vital (2): Change the version number of remote Fedora image. Add Fedora 22 information as remote ISO option src/distros.d/fedora.json | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.4.3
From: Paulo Vital <pvital@linux.vnet.ibm.com> The path of Fedora Live image points to release 21, but os_name and os_version was set up to Fedora 20. Changed to reflect only Fedora 21 information. Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com> --- src/distros.d/fedora.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/distros.d/fedora.json b/src/distros.d/fedora.json index 164415d..e5e6667 100644 --- a/src/distros.d/fedora.json +++ b/src/distros.d/fedora.json @@ -1,9 +1,9 @@ [ { - "name": "Fedora 20", + "name": "Fedora 21", "os_distro": "fedora", "os_arch": "x86_64", - "os_version": "20", + "os_version": "21", "path": "http://mirrors.kernel.org/fedora/releases/21/Live/x86_64/Fedora-Live-KDE-x86..." }, { -- 2.4.3
From: Paulo Vital <pvital@linux.vnet.ibm.com> Fedora 22 was released on Aug, 26th 2015. Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com> --- src/distros.d/fedora.json | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/distros.d/fedora.json b/src/distros.d/fedora.json index e5e6667..9dd7a7f 100644 --- a/src/distros.d/fedora.json +++ b/src/distros.d/fedora.json @@ -1,5 +1,12 @@ [ { + "name": "Fedora 22", + "os_distro": "fedora", + "os_arch": "x86_64", + "os_version": "22", + "path": "http://mirrors.kernel.org/fedora/releases/22/Live/x86_64/Fedora-Live-KDE-x86..." + }, + { "name": "Fedora 21", "os_distro": "fedora", "os_arch": "x86_64", -- 2.4.3
Reviewed-by: Aline Manera <alinefm@linux.vnet.ibm.com> On 27/08/2015 18:55, pvital@linux.vnet.ibm.com wrote:
From: Paulo Vital <pvital@linux.vnet.ibm.com>
Patch set that fixes worng information about Fedora 21 remote ISO and adds a new option to Fedora 22.
Paulo Vital (2): Change the version number of remote Fedora image. Add Fedora 22 information as remote ISO option
src/distros.d/fedora.json | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
The tests are failing with this patch set: ====================================================================== ERROR: test_distros (test_rest.RestTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_rest.py", line 1113, in test_distros self.assertEquals(distro['name'], ident) KeyError: 'name' ---------------------------------------------------------------------- Ran 1 test in 2.142s Seems you need to keep a "Fedora 20" entry in the fedora.json file, otherwise update the test case. But I'd say to add a Fedora 20 as it is not too old version. On 27/08/2015 18:55, pvital@linux.vnet.ibm.com wrote:
From: Paulo Vital <pvital@linux.vnet.ibm.com>
Patch set that fixes worng information about Fedora 21 remote ISO and adds a new option to Fedora 22.
Paulo Vital (2): Change the version number of remote Fedora image. Add Fedora 22 information as remote ISO option
src/distros.d/fedora.json | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
On Tue, 2015-09-08 at 22:22 -0300, Aline Manera wrote:
The tests are failing with this patch set:
===================================================================== = ERROR: test_distros (test_rest.RestTests) --------------------------------------------------------------------- - Traceback (most recent call last): File "test_rest.py", line 1113, in test_distros self.assertEquals(distro['name'], ident) KeyError: 'name'
--------------------------------------------------------------------- - Ran 1 test in 2.142s
Seems you need to keep a "Fedora 20" entry in the fedora.json file, otherwise update the test case.
My bad, I forgot to run the tests before submit the patches.
But I'd say to add a Fedora 20 as it is not too old version.
Looking at the the official mirrors, there's no more Fedora Live 20 available to download. However, I found it on the archives server of Fedora project. Even thinking that Fedora 20 is too old (there's a beta of Fedora 23 available to tests), I'm going to update the URL for Fedora 20 and add the options for 21 and 22.
On 27/08/2015 18:55, pvital@linux.vnet.ibm.com wrote:
From: Paulo Vital <pvital@linux.vnet.ibm.com>
Patch set that fixes worng information about Fedora 21 remote ISO and adds a new option to Fedora 22.
Paulo Vital (2): Change the version number of remote Fedora image. Add Fedora 22 information as remote ISO option
src/distros.d/fedora.json | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
participants (3)
-
Aline Manera -
Paulo Ricardo Paz Vital -
pvital＠linux.vnet.ibm.com