[PATCH] Change pattern match in pep8 filtering
From: Royce Lv <lvroyce@linux.vnet.ibm.com> Files like "./src/kimchi/i18n.py" will be warned with error by pep8 because pep8 uses wildcard searching instead of interpreting path of file. So change pattern to fix this problem. Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index ec88787..62b10fc 100644 --- a/Makefile.am +++ b/Makefile.am @@ -34,7 +34,7 @@ EXTRA_DIST = \ $(NULL) -PEP8_BLACKLIST = src/kimchi/config.py,src/kimchi/i18n.py,tests/test_config.py +PEP8_BLACKLIST = *src/kimchi/config.py,*src/kimchi/i18n.py,*tests/test_config.py SKIP_PYFLAKES_ERR = "\./src/kimchi/websocket\.py" -- 1.8.3.2
Hi Royce, I don't understand the problem you're trying to fix with this patch. The file "src/kimchi/i18n.py" is already excluded from the PEP8 verification, there shouldn't be any warnings because of that file. That's why its path is listed in PEP8_BLACKLIST. What exactly is happening? Are you getting warnings from that file when running PEP8 against it? Could you paste the output of "make check-local" here? On 19-11-2014 04:00, lvroyce@linux.vnet.ibm.com wrote:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
Files like "./src/kimchi/i18n.py" will be warned with error by pep8 because pep8 uses wildcard searching instead of interpreting path of file. So change pattern to fix this problem.
Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com>
Hi Royce,
I don't understand the problem you're trying to fix with this patch. The file "src/kimchi/i18n.py" is already excluded from the PEP8 verification, there shouldn't be any warnings because of that file. That's why its path is listed in PEP8_BLACKLIST.
What exactly is happening? Are you getting warnings from that file when running PEP8 against it? Could you paste the output of "make check-local" here?
On 2014年11月20日 01:18, Crístian Viana wrote: pep8 "--exclude" option uses command line path wildcard instead of semantic match or regular expression pattern match.--from Ubuntu 14.04 pep8 See error I got: royce@royce-ThinkPad-T420:~/kimchi-2/kimchi$ /usr/bin/pep8 --filename '*.py,*.py.in' --exclude="./src/kimchi/config.py,./src/kimchi/i18n.py,./tests/test_config.py" . royce@royce-ThinkPad-T420:~/kimchi-2/kimchi$ PYTHONPATH=./ /usr/bin/pep8 --filename '*.py,*.py.in' --exclude="src/kimchi/config.py,src/kimchi/i18n.py,tests/test_config.py" . ./src/kimchi/config.py:112:80: E501 line too long (86 > 79 characters) ./src/kimchi/config.py:153:80: E501 line too long (105 > 79 characters) ./src/kimchi/i18n.py:29:80: E501 line too long (92 > 79 characters) ./src/kimchi/i18n.py:33:80: E501 line too long (81 > 79 characters) ./src/kimchi/i18n.py:38:80: E501 line too long (95 > 79 characters) ./src/kimchi/i18n.py:40:80: E501 line too long (95 > 79 characters) ./src/kimchi/i18n.py:48:80: E501 line too long (83 > 79 characters) ./src/kimchi/i18n.py:51:80: E501 line too long (87 > 79 characters) royce@royce-ThinkPad-T420:~/kimchi-2/kimchi$ PYTHONPATH=./ /usr/bin/pep8 --filename '*.py,*.py.in' --exclude="/home/royce/kimchi-2/kimchi/src/kimchi/config.py,/home/royce/kimchi-2/kimchi/src/kimchi/i18n.py,/home/royce/kimchi-2/kimchi/tests/test_config.py" . ./src/kimchi/config.py:112:80: E501 line too long (86 > 79 characters) ./src/kimchi/config.py:153:80: E501 line too long (105 > 79 characters) ./src/kimchi/i18n.py:29:80: E501 line too long (92 > 79 characters) ./src/kimchi/i18n.py:33:80: E501 line too long (81 > 79 characters) ./src/kimchi/i18n.py:38:80: E501 line too long (95 > 79 characters)
On 19-11-2014 04:00, lvroyce@linux.vnet.ibm.com wrote:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
Files like "./src/kimchi/i18n.py" will be warned with error by pep8 because pep8 uses wildcard searching instead of interpreting path of file. So change pattern to fix this problem.
Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com>
participants (4)
-
Aline Manera -
Crístian Viana -
lvroyce＠linux.vnet.ibm.com -
Royce Lv