Reviewed-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com&gt; I have tried both SCSI and SATA are OK for cdrom.

CC Adam King: I'm so sorry. I have check again, SATA also can works. The guest can boot from SATA cdrom. Maybe I make a mistake yesterday. I have set a 14 SATA cdrom on my guest. It can works. I also check the 440FX data sheet, it can also support SATA controller. But I have not tried how manySATA controllers that it can support. Just know one SATA controllers can support 6 SATA devices. On 03/13/2014 06:47 PM, lvroyce(a)linux.vnet.ibm.com wrote: > From: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; > > CDROM cannot be extended to more than 4, > this is limitation of IDE bus. > Change default bus of cdrom to scsi to overcome this limitation. > > Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; > --- > src/kimchi/model/vmstorages.py | 2 +- > src/kimchi/osinfo.py | 6 ++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/kimchi/model/vmstorages.py > b/src/kimchi/model/vmstorages.py > index c1c90ce..b858703 100644 > --- a/src/kimchi/model/vmstorages.py > +++ b/src/kimchi/model/vmstorages.py > @@ -55,7 +55,7 @@ def _get_storage_xml(params): > source.set(DEV_TYPE_SRC_ATTR_MAP[src_type], > params.get('path')) > disk.append(source) > > - disk.append(E.target(dev=params.get('dev'), bus='ide')) > + disk.append(E.target(dev=params.get('dev'), bus='scsi')) > return ET.tostring(disk) > > > diff --git a/src/kimchi/osinfo.py b/src/kimchi/osinfo.py > index 02dbabf..8d64422 100644 > --- a/src/kimchi/osinfo.py > +++ b/src/kimchi/osinfo.py > @@ -32,7 +32,7 @@ SUPPORTED_ARCHS = {'x86': ('i386', 'x86_64'), > 'power': ('ppc', 'ppc64')} > > > common_spec = {'cpus': 1, 'cpu_cores': 1, 'cpu_threads': 1, > 'memory': 1024, > - 'disks': [{'index': 0, 'size': 10}], 'cdrom_bus': 'ide', > + 'disks': [{'index': 0, 'size': 10}], > 'cdrom_index': 2, 'mouse_bus': 'ps2'} > > > @@ -40,8 +40,10 @@ modern_spec = dict(common_spec, disk_bus='virtio', > nic_model='virtio') > > > template_specs = {'x86': {'old': dict(common_spec, disk_bus='ide', > - nic_model='e1000', > sound_model='ich6'), > + cdrom_bus='ide', > nic_model='e1000', > + sound_model='ich6'), > 'modern': dict(common_spec, > disk_bus='virtio', > + cdrom_bus='scsi', > nic_model='virtio', > sound_model='ich6')}, > 'power': {'old': dict(common_spec, disk_bus='scsi',

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; Feature test when kimchi starts, cdrom is configured to be ide, change it to be scsi to in line with our template configuration. Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; --- src/kimchi/featuretests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/kimchi/featuretests.py b/src/kimchi/featuretests.py index 045f72b..9b8f04b 100644 --- a/src/kimchi/featuretests.py +++ b/src/kimchi/featuretests.py @@ -46,10 +46,10 @@ ISO_STREAM_XML = """ <source protocol='%(protocol)s' name='/url/path/to/iso/file'> <host name='host.name' port='1234'/> </source> - <target dev='hdc' bus='ide'/> + <target dev='sr0' bus='scsi'/> <readonly/> - <alias name='ide0-1-0'/> - <address type='drive' controller='0' bus='1' target='0' unit='0'/> + <alias name='scsi0-0-1'/>

+ <address type='drive' controller='0' bus='0' target='0' unit='1'/> </disk> </devices> </domain>"""