[PATCH] UI bug fix: Properly display storage volumes on Storage tab
While selecting an active storage pool, the storage volumes in it should be listed. But commit 1fb4257f changed "hide-content" CSS class to "display: none!important" which is preveting the storage volumes to be displayed through .slideDown() function. Set "style=display:none" to the volumes div to fix it. Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com> --- ui/pages/tabs/storage.html.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/pages/tabs/storage.html.tmpl b/ui/pages/tabs/storage.html.tmpl index 34ccd21..f46632a 100644 --- a/ui/pages/tabs/storage.html.tmpl +++ b/ui/pages/tabs/storage.html.tmpl @@ -91,7 +91,7 @@ <div class="arrow-down"></div> </div> </div> - <div class="volumes hide-content"> + <div class="volumes" style="display:none"> <div id="volume{name}" class="volumeslist" data-name="{name}" ></div> <div class="clear"></div> </div> -- 1.9.3
-- Reviewed-by: Paulo Vital <pvital@linux.vnet.ibm.com> On Mon, 2014-09-01 at 15:56 -0300, Aline Manera wrote:
While selecting an active storage pool, the storage volumes in it should be listed. But commit 1fb4257f changed "hide-content" CSS class to "display: none!important" which is preveting the storage volumes to be displayed through .slideDown() function. Set "style=display:none" to the volumes div to fix it.
Signed-off-by: Aline Manera <alinefm@linux.vnet.ibm.com> --- ui/pages/tabs/storage.html.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/pages/tabs/storage.html.tmpl b/ui/pages/tabs/storage.html.tmpl index 34ccd21..f46632a 100644 --- a/ui/pages/tabs/storage.html.tmpl +++ b/ui/pages/tabs/storage.html.tmpl @@ -91,7 +91,7 @@ <div class="arrow-down"></div> </div> </div> - <div class="volumes hide-content"> + <div class="volumes" style="display:none"> <div id="volume{name}" class="volumeslist" data-name="{name}" ></div> <div class="clear"></div> </div>
- <div class="volumes hide-content"> + <div class="volumes" style="display:none"> Instead of changing the style directly in the HTML code, I think this
On 01-09-2014 15:56, Aline Manera wrote: patch should edit the class "volumes" in the appropriate CSS file (ui/css/theme-default/storage.css). That file already sets a "display" property, so we're overriding it here, there's no need to do that. And putting styles in CSS files is much easier to maintain and consistent with the rest of the code.
On 09/02/2014 01:48 PM, Crístian Viana wrote:
- <div class="volumes hide-content"> + <div class="volumes" style="display:none"> Instead of changing the style directly in the HTML code, I think this
On 01-09-2014 15:56, Aline Manera wrote: patch should edit the class "volumes" in the appropriate CSS file (ui/css/theme-default/storage.css). That file already sets a "display" property, so we're overriding it here, there's no need to do that. And putting styles in CSS files is much easier to maintain and consistent with the rest of the code.
ACK. Please, check V2
participants (3)
-
Aline Manera -
Crístian Viana -
Paulo Ricardo Paz Vital