1:43 a.m.
Take advantage of jQuery UI to make update progress area collapsible.
Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
---
ui/css/theme-default/host.css | 4 +++-
ui/js/src/kimchi.host.js | 3 +++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ui/css/theme-default/host.css b/ui/css/theme-default/host.css
index 0f8b941..e1e83ee 100644
--- a/ui/css/theme-default/host.css
+++ b/ui/css/theme-default/host.css
@@ -248,8 +248,10 @@
.host-panel #software-updates-progress-textarea {
border: 1px solid #ddd;
+ box-sizing: border-box;
height: 100px;
+ padding: .2em .5em;
resize: vertical;
- width: 846px;
+ width: 852px;
}
/* End of Software Updates */
diff --git a/ui/js/src/kimchi.host.js b/ui/js/src/kimchi.host.js
index 6300f37..f9696ea 100644
--- a/ui/js/src/kimchi.host.js
+++ b/ui/js/src/kimchi.host.js
@@ -276,6 +276,9 @@ kimchi.host_main = function() {
initSoftwareUpdatesGrid();
kimchi.topic('kimchi/softwareUpdated')
.subscribe(listSoftwareUpdates);
+ $('#software-updates-progress-container').accordion({
+ collapsible: true
+ });
}
if(capabilities['system_report_tool']) {
--
1.8.1.4
12:57 a.m.
Looking for your reviews.
On 03/13/2014 02:43 PM, Hongliang Wang wrote:
Take advantage of jQuery UI to make update progress area
collapsible.
Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
---
ui/css/theme-default/host.css | 4 +++-
ui/js/src/kimchi.host.js | 3 +++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ui/css/theme-default/host.css b/ui/css/theme-default/host.css
index 0f8b941..e1e83ee 100644
--- a/ui/css/theme-default/host.css
+++ b/ui/css/theme-default/host.css
@@ -248,8 +248,10 @@
.host-panel #software-updates-progress-textarea {
border: 1px solid #ddd;
+ box-sizing: border-box;
height: 100px;
+ padding: .2em .5em;
resize: vertical;
- width: 846px;
+ width: 852px;
}
/* End of Software Updates */
diff --git a/ui/js/src/kimchi.host.js b/ui/js/src/kimchi.host.js
index 6300f37..f9696ea 100644
--- a/ui/js/src/kimchi.host.js
+++ b/ui/js/src/kimchi.host.js
@@ -276,6 +276,9 @@ kimchi.host_main = function() {
initSoftwareUpdatesGrid();
kimchi.topic('kimchi/softwareUpdated')
.subscribe(listSoftwareUpdates);
+ $('#software-updates-progress-container').accordion({
+ collapsible: true
+ });
}
if(capabilities['system_report_tool']) {
3:51 p.m.
We'd like to be able to close/dismiss the progress area, rather than
just hide/show the contents.
On 3/13/2014 2:43 AM, Hongliang Wang wrote:
Take advantage of jQuery UI to make update progress area
collapsible.
Signed-off-by: Hongliang Wang<hlwang(a)linux.vnet.ibm.com>
--
Adam King <rak(a)linux.vnet.ibm.com>
IBM C&SI
12:55 p.m.
On 03/14/2014 05:51 PM, Adam King wrote:
We'd like to be able to close/dismiss the progress area, rather
than
just hide/show the contents.
Hongliang,
will you send a new patch series with Adam's suggestion?
On 3/13/2014 2:43 AM, Hongliang Wang wrote:
> Take advantage of jQuery UI to make update progress area collapsible.
>
> Signed-off-by: Hongliang Wang<hlwang(a)linux.vnet.ibm.com>
2:53 a.m.
Hi Adam & Aline, for current stage, I still suggest keep hide/show other
than close/dismiss.
For a reasonable user experience, I think we need 2 views: summary
and detailed.
*Summary View:*
=======================
Updating software...
____________________
_|50%___|
? Details
=======================
*Detailed View:*
=======================
Updating software...
____________________
_|50%___|
? Details
Updating package 1... Finished!
Updating package 2... Finished!
Updating package 3... Finished!
Updating package 4... Finished!
Updating package 5...
=======================
For user, *progress* is the key information he/she wants. Here,
let's take a look at the 2 views:
1) With the overall progress percentage, the user can estimate a
finish time that he can switch back when the updating is done.
2) With the detailed information, the user may have the chance to
correct something, for example, after several updates, the user found
the updating always fails at 50%, so he/she open the detailed view to
find the corresponding package and take some action.
In our current back-end implementation, the user can only know the
detailed information and not obvious total progress. If we allow
close/dismiss the progress area, the user will lose everything about the
progress.
On 04/02/2014 01:55 AM, Aline Manera wrote:
On 03/14/2014 05:51 PM, Adam King wrote:
> We'd like to be able to close/dismiss the progress area, rather than
> just hide/show the contents.
Hongliang,
will you send a new patch series with Adam's suggestion?
>
> On 3/13/2014 2:43 AM, Hongliang Wang wrote:
>> Take advantage of jQuery UI to make update progress area collapsible.
>>
>> Signed-off-by: Hongliang Wang<hlwang(a)linux.vnet.ibm.com>
>
_______________________________________________
Kimchi-devel mailing list
Kimchi-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/kimchi-devel
8:18 p.m.
On 04/03/2014 04:53 AM, Hongliang Wang wrote:
Hi Adam & Aline, for current stage, I still suggest keep
hide/show
other than close/dismiss.
For a reasonable user experience, I think we need 2 views: summary
and detailed.
*Summary View:*
=======================
Updating software...
____________________
_|50%___|
? Details
=======================
*Detailed View:*
=======================
Updating software...
____________________
_|50%___|
? Details
Updating package 1... Finished!
Updating package 2... Finished!
Updating package 3... Finished!
Updating package 4... Finished!
Updating package 5...
=======================
For user, *progress* is the key information he/she wants. Here,
let's take a look at the 2 views:
1) With the overall progress percentage, the user can estimate a
finish time that he can switch back when the updating is done.
2) With the detailed information, the user may have the chance to
correct something, for example, after several updates, the user found
the updating always fails at 50%, so he/she open the detailed view to
find the corresponding package and take some action.
In our current back-end implementation, the user can only know the
detailed information and not obvious total progress. If we allow
close/dismiss the progress area, the user will lose everything about
the progress.
Ok.
I will add your idea about overall and detailed view to our backlog
On 04/02/2014 01:55 AM, Aline Manera wrote:
> On 03/14/2014 05:51 PM, Adam King wrote:
>> We'd like to be able to close/dismiss the progress area, rather than
>> just hide/show the contents.
>
> Hongliang,
>
> will you send a new patch series with Adam's suggestion?
>
>>
>> On 3/13/2014 2:43 AM, Hongliang Wang wrote:
>>> Take advantage of jQuery UI to make update progress area collapsible.
>>>
>>> Signed-off-by: Hongliang Wang<hlwang(a)linux.vnet.ibm.com>
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
3662
days inactive
3691
days old
6 comments
3 participants
participants (3)
-
Adam King -
Aline Manera -
Hongliang Wang