Hi team, Last year Twitter announced the new version of Bootstrap. Wok currently uses a customized version of Bootstrap 3 Sass / SCSS files and looking at the Alpha code it seems that porting Wok to the new version won’t be difficult: http://v4-alpha.getbootstrap.com/migration/

-Browser Support: Ok! -SCSS environment: Ok! -Dropped glyphicons: Ok! We already use Font-Awesome - Non-responsive usage of Bootstrap is no longer supported: Ok! I recognize some classes from this document and I think that a minor drawback would be with the Media Queries that were already implemented throughout the application and some changes with the classes names. Ginger uses a lot of “panel-“ classes that were replaced by “cards”, the “btn-default” button was renamed to “btn-secondary” and etc. The major issue is with jQuery Bootgrid plugin. It seems that they’re not planning to port to Bootstrap 4 until it gets stable. I think we should port our jQuery Bootgrid code to Datatables.net, since it has a vast documentation and it already supports Bootstrap 4: https://datatables.net/examples/styling/bootstrap4.html Any comments?

Samuel _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel

On 05/24/2016 05:58 AM, Chandra Shekhar Reddy Potula wrote: > > > > On 5/23/16 10:30 PM, Samuel Henrique De Oliveira Guimaraes wrote: >> >> Hi team, >> >> Last year Twitter announced the new version of Bootstrap. Wok >> currently uses a customized version of Bootstrap 3 Sass / SCSS files >> and looking at the Alpha code it seems that porting Wok to the new >> version won’t be difficult: >> >> http://v4-alpha.getbootstrap.com/migration/ >> > Samuel, Thanks for the RFC !!! > For my education, is this official final bootstrap 4 version or is it > still kind of non stable version (alpha sounds like that to me) ? If > so when will be the official bootstrap 4 ? >> >> -Browser Support: Ok! >> >> -SCSS environment: Ok! >> >> -Dropped glyphicons: Ok! We already use Font-Awesome >> >> - Non-responsive usage of Bootstrap is no longer supported: Ok! >> >> I recognize some classes from this document and I think that a minor >> drawback would be with the Media Queries that were already >> implemented throughout the application and some changes with the >> classes names. Ginger uses a lot of “panel-“ classes that were >> replaced by “cards”, the “btn-default” button was renamed to >> “btn-secondary” and etc. >> >> The major issue is with jQuery Bootgrid plugin. It seems that >> they’re not planning to port to Bootstrap 4 until it gets stable. I >> think we should port our jQuery Bootgrid code to Datatables.net, >> since it has a vast documentation and it already supports Bootstrap 4: >> >> https://datatables.net/examples/styling/bootstrap4.html >> >> Any comments? >> > This will be major concerns as I feel lot of work if we have to do this. > > When you say "It seems that they’re not planning to port to Bootstrap > 4 until it gets stable"? Do you mean until bootstrap 4 not stabilized > bootgrid team will not port or bootgrid itself have stabilization > issues and they would not port until they stabilize bootgrid ? > > If we have an answer that bootgrid team will wait till bootstrap 4 > get stabilized then I would not hurry in porting our jQuery Bootgrid > code to Datatables.net, since it will involve huge effort in porting > and at the same time in testing. I agree. Perhaps we should wait until Bootstrap 4 is stable too ... > > So in my opinion, readiness is good idea but at the same time we > have to make sure we are not spending efforts in porting any of the > existing code unless we know that there will be no support at all !!! > > We have to take conscious decision !!! >> >> Samuel >> >> >> >> _______________________________________________ >> Kimchi-devel mailing list >> Kimchi-devel(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/kimchi-devel > > > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel

*From:*kimchi-devel-bounces@ovirt.org [mailto:kimchi-devel-bounces@ovirt.org] *On Behalf Of *Atreye Mukhopadhyay *Sent:* terça-feira, 24 de maio de 2016 08:19 *To:* kimchi-devel(a)ovirt.org *Subject:* Re: [Kimchi-devel] [WOK] [RFC} Checking Bootstrap 4 compatibility + dropping jQuery Bootgrid I agree with Daniel and Chandra. We should wait for stable bootstrap 4 version. On 5/24/2016 4:38 PM, Daniel Henrique Barboza wrote: On 05/24/2016 05:58 AM, Chandra Shekhar Reddy Potula wrote: On 5/23/16 10:30 PM, Samuel Henrique De Oliveira Guimaraes wrote: Hi team, Last year Twitter announced the new version of Bootstrap. Wok currently uses a customized version of Bootstrap 3 Sass / SCSS files and looking at the Alpha code it seems that porting Wok to the new version won’t be difficult: http://v4-alpha.getbootstrap.com/migration/ Samuel, Thanks for the RFC !!! For my education, is this official final bootstrap 4 version or is it still kind of non stable version (alpha sounds like that to me) ? If so when will be the official bootstrap 4 ? Yes, it is an Alpha version and they are still working and providing support for Bootstrap 3. They don’t post a roadmap but judging by Bootstrap 3 release log, they took almost a year to move from RC2 to the first stable release, however, their community is bigger now and I don’t think they discarded everything from the old code in this new version so it may take less time until we have a public stable release. This is just a study for future Wok releases. -Browser Support: Ok! -SCSS environment: Ok! -Dropped glyphicons: Ok! We already use Font-Awesome - Non-responsive usage of Bootstrap is no longer supported: Ok! I recognize some classes from this document and I think that a minor drawback would be with the Media Queries that were already implemented throughout the application and some changes with the classes names. Ginger uses a lot of “panel-“ classes that were replaced by “cards”, the “btn-default” button was renamed to “btn-secondary” and etc. The major issue is with jQuery Bootgrid plugin. It seems that they’re not planning to port to Bootstrap 4 until it gets stable. I think we should port our jQuery Bootgrid code to Datatables.net, since it has a vast documentation and it already supports Bootstrap 4: https://datatables.net/examples/styling/bootstrap4.html Any comments? This will be major concerns as I feel lot of work if we have to do this. When you say "It seems that they’re not planning to port to Bootstrap 4 until it gets stable"? Do you mean until bootstrap 4 not stabilized bootgrid team will not port or bootgrid itself have stabilization issues and they would not port until they stabilize bootgrid ? I’ve meant until Bootgrid is more stable and Bootstrap 4 final is released. They (Bootgrid team) don’t have any roadmap on their project, I’ve searched the Github page and found nothing. I’ll try to reach the author to get a confirmation but the main reason why I suggested Datatables.net is due documentation and support. Datatables code is under MIT and they have a paid and free support forums. I may have to install Bootstrap 4 alpha and jQuery Bootgrid current version to test compatibility but we already applied our styles over Bootgrid / Bootstrap tables and they work fine so we don’t have to discard them if Bootstrap 4 final is released and Bootgrid isn’t updated, as long as the JS keeps working without any error. With Sass it is really easy to “namespace” some classes and keep the old Bootstrap table classes with the new ones if necessary. I did some digging and so far the only incompatible items I’ve seen are the Sort / Unsort icons and the pagination links (prev, next, first, last and the numbers). Within our Wok customization we already replaced the sort icons with FontAwesome and I’m sure it is not difficult to replace the pagination links if we have to. If we have an answer that bootgrid team will wait till bootstrap 4 get stabilized then I would not hurry in porting our jQuery Bootgrid code to Datatables.net, since it will involve huge effort in porting and at the same time in testing. I agree. Perhaps we should wait until Bootstrap 4 is stable too ... I didn’t say that we should hurry and get the new Bootstrap as soon as it is released but we should keep an eye for the changes and measure the efforts in case we decide to update. Bootstrap 3.3.6 had tons of fixes and changes from Bootstrap 3.2.0 for instance, mainly in JS but some in the CSS to support new and old browsers. So in my opinion, readiness is good idea but at the same time we have to make sure we are not spending efforts in porting any of the existing code unless we know that there will be no support at all !!! We have to take conscious decision !!! Samuel _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org <mailto:Kimchi-devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/kimchi-devel _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org <mailto:Kimchi-devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/kimchi-devel _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org <mailto:Kimchi-devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/kimchi-devel _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel