[PATCH] remove unused InvalidOperation instance

From: ShaoHe Feng <shaohef@linux.vnet.ibm.com> Neither of these two removed InvalidOperation is used. Signed-off-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com> --- src/kimchi/auth.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/kimchi/auth.py b/src/kimchi/auth.py index f8ccea1..af3b610 100644 --- a/src/kimchi/auth.py +++ b/src/kimchi/auth.py @@ -197,13 +197,11 @@ def kimchiauth(admin_methods=None): debug("Entering kimchiauth...") if check_auth_session(): if not has_permission(admin_methods): - e = InvalidOperation('KCHAUTH0004E') raise cherrypy.HTTPError(403) return if check_auth_httpba(): if not has_permission(admin_methods): - e = InvalidOperation('KCHAUTH0004E') raise cherrypy.HTTPError(403) return -- 1.8.4.2

Reviewed-by: Shu Ming <shuming@linux.vnet.ibm.com> 于 2014/3/4 18:01, shaohef@linux.vnet.ibm.com 写道:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>
Neither of these two removed InvalidOperation is used.
Signed-off-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com> --- src/kimchi/auth.py | 2 -- 1 file changed, 2 deletions(-)
diff --git a/src/kimchi/auth.py b/src/kimchi/auth.py index f8ccea1..af3b610 100644 --- a/src/kimchi/auth.py +++ b/src/kimchi/auth.py @@ -197,13 +197,11 @@ def kimchiauth(admin_methods=None): debug("Entering kimchiauth...") if check_auth_session(): if not has_permission(admin_methods): - e = InvalidOperation('KCHAUTH0004E') raise cherrypy.HTTPError(403) return
if check_auth_httpba(): if not has_permission(admin_methods): - e = InvalidOperation('KCHAUTH0004E') raise cherrypy.HTTPError(403) return

Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com> On 03/04/2014 07:01 AM, shaohef@linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef@linux.vnet.ibm.com>
Neither of these two removed InvalidOperation is used.
Signed-off-by: ShaoHe Feng <shaohef@linux.vnet.ibm.com> --- src/kimchi/auth.py | 2 -- 1 file changed, 2 deletions(-)
diff --git a/src/kimchi/auth.py b/src/kimchi/auth.py index f8ccea1..af3b610 100644 --- a/src/kimchi/auth.py +++ b/src/kimchi/auth.py @@ -197,13 +197,11 @@ def kimchiauth(admin_methods=None): debug("Entering kimchiauth...") if check_auth_session(): if not has_permission(admin_methods): - e = InvalidOperation('KCHAUTH0004E') raise cherrypy.HTTPError(403) return
if check_auth_httpba(): if not has_permission(admin_methods): - e = InvalidOperation('KCHAUTH0004E') raise cherrypy.HTTPError(403) return
participants (4)
-
Aline Manera
-
Daniel H Barboza
-
shaohef@linux.vnet.ibm.com
-
Shu Ming