[PATCH v2][Kimchi] Fix when calling error message in storagepool
Error message was waiting a string with index "pool", instead of "name" Signed-off-by: Ramon Medeiros <ramonn@linux.vnet.ibm.com> --- Changes: v2: Use poolname instead of pool.name() model/storagevolumes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/storagevolumes.py b/model/storagevolumes.py index 91e1c6b..7b2272b 100644 --- a/model/storagevolumes.py +++ b/model/storagevolumes.py @@ -284,7 +284,7 @@ class StorageVolumeModel(object): def get_storagevolume(poolname, name, conn): pool = StoragePoolModel.get_storagepool(poolname, conn) if not pool.isActive(): - raise InvalidOperation("KCHVOL0006E", {'name': pool}) + raise InvalidOperation("KCHVOL0006E", {'pool': poolname}) try: return pool.storageVolLookupByName(name.encode("utf-8")) except libvirt.libvirtError as e: -- 2.5.5
Reviewed-By: Lucio Correia <luciojhc@linux.vnet.ibm.com> On 19-08-2016 00:37, Ramon Medeiros wrote:
Error message was waiting a string with index "pool", instead of "name"
Signed-off-by: Ramon Medeiros <ramonn@linux.vnet.ibm.com> --- Changes:
v2: Use poolname instead of pool.name()
model/storagevolumes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/model/storagevolumes.py b/model/storagevolumes.py index 91e1c6b..7b2272b 100644 --- a/model/storagevolumes.py +++ b/model/storagevolumes.py @@ -284,7 +284,7 @@ class StorageVolumeModel(object): def get_storagevolume(poolname, name, conn): pool = StoragePoolModel.get_storagepool(poolname, conn) if not pool.isActive(): - raise InvalidOperation("KCHVOL0006E", {'name': pool}) + raise InvalidOperation("KCHVOL0006E", {'pool': poolname}) try: return pool.storageVolLookupByName(name.encode("utf-8")) except libvirt.libvirtError as e:
-- Lucio Correia Software Engineer IBM LTC Brazil
Applied to master. Thanks! On 08/19/2016 12:37 AM, Ramon Medeiros wrote:
Error message was waiting a string with index "pool", instead of "name"
Signed-off-by: Ramon Medeiros <ramonn@linux.vnet.ibm.com> --- Changes:
v2: Use poolname instead of pool.name()
model/storagevolumes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/model/storagevolumes.py b/model/storagevolumes.py index 91e1c6b..7b2272b 100644 --- a/model/storagevolumes.py +++ b/model/storagevolumes.py @@ -284,7 +284,7 @@ class StorageVolumeModel(object): def get_storagevolume(poolname, name, conn): pool = StoragePoolModel.get_storagepool(poolname, conn) if not pool.isActive(): - raise InvalidOperation("KCHVOL0006E", {'name': pool}) + raise InvalidOperation("KCHVOL0006E", {'pool': poolname}) try: return pool.storageVolLookupByName(name.encode("utf-8")) except libvirt.libvirtError as e:
participants (3)
-
Daniel Henrique Barboza -
Lucio Correia -
Ramon Medeiros