[PATCH] [Kimchi] Edit template storage path should start with "/"

From: Rajat Gupta <rajat.triumph@gmail.com> Edit template storage path should start with "/" Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/js/src/kimchi.template_edit_main.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/js/src/kimchi.template_edit_main.js b/ui/js/src/kimchi.template_edit_main.js index 1a6e473..758201f 100644 --- a/ui/js/src/kimchi.template_edit_main.js +++ b/ui/js/src/kimchi.template_edit_main.js @@ -339,7 +339,8 @@ kimchi.template_edit_main = function() { }); $(storageRow + ' input.storage-path').on('change input keyup',function(){ - if($(storageRow + ' input.storage-path').val()){ + var storagepath = $(storageRow + ' input.storage-path').val(); + if( storagepath && storagepath.charAt(0) == '/'){ $(storageRow + ' span.storage-path').removeClass('has-error'); }else{ $(storageRow + ' span.storage-path').addClass('has-error'); -- 2.1.0

Reviewed-By: Lucio Correia <luciojhc@linux.vnet.ibm.com> On 02/11/2016 06:58, rajgupta@linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph@gmail.com>
Edit template storage path should start with "/"
Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/js/src/kimchi.template_edit_main.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/js/src/kimchi.template_edit_main.js b/ui/js/src/kimchi.template_edit_main.js index 1a6e473..758201f 100644 --- a/ui/js/src/kimchi.template_edit_main.js +++ b/ui/js/src/kimchi.template_edit_main.js @@ -339,7 +339,8 @@ kimchi.template_edit_main = function() { });
$(storageRow + ' input.storage-path').on('change input keyup',function(){ - if($(storageRow + ' input.storage-path').val()){ + var storagepath = $(storageRow + ' input.storage-path').val(); + if( storagepath && storagepath.charAt(0) == '/'){ $(storageRow + ' span.storage-path').removeClass('has-error'); }else{ $(storageRow + ' span.storage-path').addClass('has-error');
-- Lucio Correia Software Engineer IBM LTC Brazil

Is there an information somewhere to let user know that restriction? On 11/02/2016 06:58 AM, rajgupta@linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph@gmail.com>
Edit template storage path should start with "/"
Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/js/src/kimchi.template_edit_main.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/js/src/kimchi.template_edit_main.js b/ui/js/src/kimchi.template_edit_main.js index 1a6e473..758201f 100644 --- a/ui/js/src/kimchi.template_edit_main.js +++ b/ui/js/src/kimchi.template_edit_main.js @@ -339,7 +339,8 @@ kimchi.template_edit_main = function() { });
$(storageRow + ' input.storage-path').on('change input keyup',function(){ - if($(storageRow + ' input.storage-path').val()){ + var storagepath = $(storageRow + ' input.storage-path').val(); + if( storagepath && storagepath.charAt(0) == '/'){ $(storageRow + ' span.storage-path').removeClass('has-error'); }else{ $(storageRow + ' span.storage-path').addClass('has-error');

Hello Aline, On key press we have validation to display text box in red color if path is not valid, also when user try to save data message is getting display as below Once user input correct path red border will disappear as below Thanks and Regards, Rajat Gupta On 11/5/2016 1:37 AM, Aline Manera wrote:
Is there an information somewhere to let user know that restriction?
On 11/02/2016 06:58 AM, rajgupta@linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph@gmail.com>
Edit template storage path should start with "/"
Signed-off-by: Rajat Gupta <rajat.triumph@gmail.com> --- ui/js/src/kimchi.template_edit_main.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/js/src/kimchi.template_edit_main.js b/ui/js/src/kimchi.template_edit_main.js index 1a6e473..758201f 100644 --- a/ui/js/src/kimchi.template_edit_main.js +++ b/ui/js/src/kimchi.template_edit_main.js @@ -339,7 +339,8 @@ kimchi.template_edit_main = function() { });
$(storageRow + ' input.storage-path').on('change input keyup',function(){ - if($(storageRow + ' input.storage-path').val()){ + var storagepath = $(storageRow + ' input.storage-path').val(); + if( storagepath && storagepath.charAt(0) == '/'){ $(storageRow + ' span.storage-path').removeClass('has-error'); }else{ $(storageRow + ' span.storage-path').addClass('has-error');

Applied. Thanks. Regards, Aline Manera
participants (4)
-
Aline Manera
-
Lucio Correia
-
Rajat Gupta
-
rajgupta@linux.vnet.ibm.com