[PATCH] [Kimchi] Issue 814: UI just show exported NFS path when clicked twice at field
From: Samuel Guimarães <sguimaraes943@gmail.com> I wasn't able to reproduce the issue with a nfs path pointing to localhost but I did tested with two NFS paths in a NFS server and found that wok.combobox() and wok.selectFilter() dropdowns were showing an empty list. If the list is empty their objects are destroyed but the validation still occurs when the user types a valid ip address and a nfs path. Samuel Guimarães (1): Issue 814: UI just show exported NFS path when clicked twice at field ui/js/src/kimchi.storagepool_add_main.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 1.9.3
From: Samuel Guimarães <sguimaraes943@gmail.com> Signed-off-by: Samuel Guimarães <sguimaraes943@gmail.com> --- ui/js/src/kimchi.storagepool_add_main.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js index dd81fef..eea0f03 100644 --- a/ui/js/src/kimchi.storagepool_add_main.js +++ b/ui/js/src/kimchi.storagepool_add_main.js @@ -187,7 +187,6 @@ kimchi.initStorageAddPage = function() { } }); - //$('#poolTypeId').selectMenu(); $('#serverComboboxId').combobox(); $('#targetFilterSelectId').filterselect(); var options = [ { @@ -223,8 +222,11 @@ kimchi.initStorageAddPage = function() { value : value.host }); }); + $('#serverComboboxId').combobox("setData", serverContent); + }else { + $('#serverComboboxId').combobox("destroy"); } - $('#serverComboboxId').combobox("setData", serverContent); + $('input[name=nfsServerType]').change(function() { if ($(this).val() === 'input') { $('#nfsServerInputDiv').removeClass('tmpl-html'); @@ -254,8 +256,10 @@ kimchi.initStorageAddPage = function() { value : value.target }); }); + $('#targetFilterSelectId').filterselect("setData", targetContent); + }else { + $('#targetFilterSelectId').filterselect('destroy'); } - $('#targetFilterSelectId').filterselect("setData", targetContent); }); }); }); -- 1.9.3
Reviewed-By: Ramon Medeiros <ramonn@br.ibm.com> On 03/16/2016 04:43 PM, sguimaraes943@gmail.com wrote:
From: Samuel Guimarães <sguimaraes943@gmail.com>
Signed-off-by: Samuel Guimarães <sguimaraes943@gmail.com> --- ui/js/src/kimchi.storagepool_add_main.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js index dd81fef..eea0f03 100644 --- a/ui/js/src/kimchi.storagepool_add_main.js +++ b/ui/js/src/kimchi.storagepool_add_main.js @@ -187,7 +187,6 @@ kimchi.initStorageAddPage = function() { } });
- //$('#poolTypeId').selectMenu(); $('#serverComboboxId').combobox(); $('#targetFilterSelectId').filterselect(); var options = [ { @@ -223,8 +222,11 @@ kimchi.initStorageAddPage = function() { value : value.host }); }); + $('#serverComboboxId').combobox("setData", serverContent); + }else { + $('#serverComboboxId').combobox("destroy"); } - $('#serverComboboxId').combobox("setData", serverContent); + $('input[name=nfsServerType]').change(function() { if ($(this).val() === 'input') { $('#nfsServerInputDiv').removeClass('tmpl-html'); @@ -254,8 +256,10 @@ kimchi.initStorageAddPage = function() { value : value.target }); }); + $('#targetFilterSelectId').filterselect("setData", targetContent); + }else { + $('#targetFilterSelectId').filterselect('destroy'); } - $('#targetFilterSelectId').filterselect("setData", targetContent); }); }); });
-- Ramon Nunes Medeiros Kimchi Developer Linux Technology Center Brazil IBM Systems & Technology Group Phone : +55 19 2132 7878 ramonn@br.ibm.com
Applied. Thanks. Regards, Aline Manera
participants (3)
-
Aline Manera -
Ramon Medeiros -
sguimaraes943＠gmail.com