1:16 p.m.
V1 -> V2:
- Add qcow and vmdk as supported format to storage volume
Royce Lv (1):
Guest storage: fix volume format overwrite
src/kimchi/model/vmstorages.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
1.9.3
1:16 p.m.
New subject: [PATCH] Guest storage: fix volume format overwrite
From: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
When vol_info reports unsupported type, such as an iscsi volume with type
'unknown',
use 'raw' without overwriting it, this applied to type 'unknown',
'iso'
and so on.
Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
---
src/kimchi/model/vmstorages.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/kimchi/model/vmstorages.py b/src/kimchi/model/vmstorages.py
index 537edbb..40856d3 100644
--- a/src/kimchi/model/vmstorages.py
+++ b/src/kimchi/model/vmstorages.py
@@ -152,7 +152,10 @@ class VMStoragesModel(object):
raise InvalidParameter("KCHVMSTOR0015E", {'error': e})
if vol_info['ref_cnt'] != 0:
raise InvalidParameter("KCHVMSTOR0016E")
- params['format'] = vol_info['format']
+
+ supported_format = ["raw", "bochs", "qcow",
"qcow2", "qed", "vmdk"]
+ if vol_info['format'] in supported_format:
+ params['format'] = vol_info['format']
params['path'] = vol_info['path']
params['src_type'] = _check_path(params['path'])
if (params['bus'] not in HOTPLUG_TYPE
--
1.9.3
2:54 p.m.
--
Reviewed-by: Paulo Vital <pvital(a)linux.vnet.ibm.com>
On Mon, 2014-09-01 at 15:16 -0300, Aline Manera wrote:
V1 -> V2:
- Add qcow and vmdk as supported format to storage volume
Royce Lv (1):
Guest storage: fix volume format overwrite
src/kimchi/model/vmstorages.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
2:57 p.m.
New subject: [PATCH] Guest storage: fix volume format overwrite
Reviewed-by: Daniel Barboza <danielhb(a)linux.vnet.ibm.com>
On 09/01/2014 03:16 PM, Aline Manera wrote:
From: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
When vol_info reports unsupported type, such as an iscsi volume with type
'unknown',
use 'raw' without overwriting it, this applied to type 'unknown',
'iso'
and so on.
Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
---
src/kimchi/model/vmstorages.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/kimchi/model/vmstorages.py b/src/kimchi/model/vmstorages.py
index 537edbb..40856d3 100644
--- a/src/kimchi/model/vmstorages.py
+++ b/src/kimchi/model/vmstorages.py
@@ -152,7 +152,10 @@ class VMStoragesModel(object):
raise InvalidParameter("KCHVMSTOR0015E", {'error':
e})
if vol_info['ref_cnt'] != 0:
raise InvalidParameter("KCHVMSTOR0016E")
- params['format'] = vol_info['format']
+
+ supported_format = ["raw", "bochs", "qcow",
"qcow2", "qed", "vmdk"]
+ if vol_info['format'] in supported_format:
+ params['format'] = vol_info['format']
params['path'] = vol_info['path']
params['src_type'] = _check_path(params['path'])
if (params['bus'] not in HOTPLUG_TYPE
10:21 p.m.
Reviewed-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com>
Thanks, Aline.
On 2014年09月02日 02:16, Aline Manera wrote:
V1 -> V2:
- Add qcow and vmdk as supported format to storage volume
Royce Lv (1):
Guest storage: fix volume format overwrite
src/kimchi/model/vmstorages.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
3517
days inactive
3518
days old
5 comments
4 participants
participants (4)
-
Aline Manera -
Daniel H Barboza -
Paulo Ricardo Paz Vital -
Royce Lv