[PATCH V2] [Kimchi] Added check for s390x architecture to not add graphics in params as not supported.

From: Archana Singh <archus@linux.vnet.ibm.com> Added check for s390x architecture to not add graphics in params as not supported on s390x architecture. Archana Singh (1): Added check for s390x architecture to not add graphics in params as not supported. vmtemplate.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.7.4

From: Archana Singh <archus@linux.vnet.ibm.com> Added check for s390x architecture to not add graphics in params as not supported on s390x architecture. Signed-off-by: Archana Singh <archus@linux.vnet.ibm.com> --- vmtemplate.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vmtemplate.py b/vmtemplate.py index ef92914..dc81fe2 100644 --- a/vmtemplate.py +++ b/vmtemplate.py @@ -350,7 +350,10 @@ class VMTemplate(object): graphics = dict(self.info['graphics']) graphics.update(kwargs.get('graphics', {})) - params['graphics'] = get_graphics_xml(graphics) + # Graphics is not supported on s390x, this check will + # not add graphics tag in domain xml. + if params['arch'] not in ['s390x']: + params['graphics'] = get_graphics_xml(graphics) libvirt_stream_protocols = kwargs.get('libvirt_stream_protocols', []) cdrom_xml = self._get_cdrom_xml(libvirt_stream_protocols) -- 2.7.4

Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com> On 08/10/2016 03:43 AM, archus@linux.vnet.ibm.com wrote:
From: Archana Singh <archus@linux.vnet.ibm.com>
Added check for s390x architecture to not add graphics in params as not supported on s390x architecture.
Archana Singh (1): Added check for s390x architecture to not add graphics in params as not supported.
vmtemplate.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)

Applied to master. Thanks! On 08/10/2016 03:43 AM, archus@linux.vnet.ibm.com wrote:
From: Archana Singh <archus@linux.vnet.ibm.com>
Added check for s390x architecture to not add graphics in params as not supported on s390x architecture.
Archana Singh (1): Added check for s390x architecture to not add graphics in params as not supported.
vmtemplate.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
participants (2)
-
archus@linux.vnet.ibm.com
-
Daniel Henrique Barboza