From: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; When creating vm on SCSI/iSCSI pools, volume needs to be specified. API.md and doc need to be updated. Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; --- docs/API.md | 1 + src/kimchi/API.json | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/docs/API.md b/docs/API.md index 4f51dd0..7a3076b 100644 --- a/docs/API.md +++ b/docs/API.md @@ -183,6 +183,7 @@ Represents a snapshot of the Virtual Machine's primary monitor. (either *size* or *volume* must be specified): * index: The device index * size: The device size in GB + * volume: LUN of SCSI or iSCSI storage. * graphics *(optional)*: The graphics paramenters of this template * type: The type of graphics. It can be VNC or spice or None. diff --git a/src/kimchi/API.json b/src/kimchi/API.json index 6d1324c..ea1eb61 100644 --- a/src/kimchi/API.json +++ b/src/kimchi/API.json @@ -381,7 +381,13 @@ "type": "number", "minimum": 1, "error": "KCHTMPL0022E" + }, + "volume": { + "description": "LUN of SCSI or iSCSI storage", + "type": "string", + "minLength": 1 } + } }, "minItems": 1,

See inline comments below. On 07/01/2014 05:43 PM, lvroyce(a)linux.vnet.ibm.com wrote: > From: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; > > When creating vm on SCSI/iSCSI pools, volume needs to be specified. > API.md and doc need to be updated. > > Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; > --- > docs/API.md | 1 + > src/kimchi/API.json | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/docs/API.md b/docs/API.md > index 4f51dd0..7a3076b 100644 > --- a/docs/API.md > +++ b/docs/API.md > @@ -183,6 +183,7 @@ Represents a snapshot of the Virtual Machine's > primary monitor. > (either *size* or *volume* must be specified): > * index: The device index > * size: The device size in GB > + * volume: LUN of SCSI or iSCSI storage. please check the commit: 279a710 In 279a710, we remove the volume, for we do not support create a vm from a volume. I'd like to say, the volume should not only be LUN, but also can be others. The original idea is that we can create a vm from any valid volume.

You can cherry-pick the patch. Also update the testcase and validate_integrity.

> > * graphics *(optional)*: The graphics paramenters of this template > * type: The type of graphics. It can be VNC or spice or None. > diff --git a/src/kimchi/API.json b/src/kimchi/API.json > index 6d1324c..ea1eb61 100644 > --- a/src/kimchi/API.json > +++ b/src/kimchi/API.json > @@ -381,7 +381,13 @@ > "type": "number", > "minimum": 1, > "error": "KCHTMPL0022E" > + }, > + "volume": { > + "description": "LUN of SCSI or iSCSI > storage", > + "type": "string", > + "minLength": 1 > } > + > } > }, > "minItems": 1,