11:31 a.m.
From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
After we list the storage pools, it will change other element with the
same class attribute in other page.
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
---
ui/js/src/kimchi.storage_main.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js
index c2c721d..6052510 100644
--- a/ui/js/src/kimchi.storage_main.js
+++ b/ui/js/src/kimchi.storage_main.js
@@ -49,7 +49,7 @@ kimchi.storageBindClick = function() {
}
});
- $('.active').each(function(index) {
+ $('.list-storage .storage-state .active').each(function(index) {
if ('active' === $(this).data('state')) {
$(this).show();
} else {
--
1.8.5.3
11:31 a.m.
New subject: [PATCH 2/2] but fix: show the content of combobox and filterselect in storage add page
From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
On firefox 27, the content of combobox and filterselect will hide.
a similar problem on issue.
https://github.com/kimchi-project/kimchi/issues/335
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
---
ui/css/theme-default/storage.css | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ui/css/theme-default/storage.css b/ui/css/theme-default/storage.css
index db3a62b..1139bd8 100644
--- a/ui/css/theme-default/storage.css
+++ b/ui/css/theme-default/storage.css
@@ -578,3 +578,7 @@
.storage-auth-width {
width: 150px;
}
+
+.storage-window .form-section .field {
+ overflow: visible;
+}
--
1.8.5.3
3:49 a.m.
New subject: [PATCH 2/2] but fix: show the content of combobox and filterselect in storage add page
On 03/24/2014 06:31 AM, shaohef(a)linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
On firefox 27, the content of combobox and filterselect will hide.
a similar problem on issue.
https://github.com/kimchi-project/kimchi/issues/335
I didn't understand the relation between this patch an the issue listed
above.
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
---
ui/css/theme-default/storage.css | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ui/css/theme-default/storage.css b/ui/css/theme-default/storage.css
index db3a62b..1139bd8 100644
--- a/ui/css/theme-default/storage.css
+++ b/ui/css/theme-default/storage.css
@@ -578,3 +578,7 @@
.storage-auth-width {
width: 150px;
}
+
+.storage-window .form-section .field {
+ overflow: visible;
+}
Is it to show the combo box when it is at the end of the window?
4:32 a.m.
New subject: [PATCH 2/2] but fix: show the content of combobox and filterselect in storage add page
On 03/25/2014 09:49 AM, Aline Manera wrote:
--
Thanks and best regards!
Sheldon Feng(???)<shaohef(a)linux.vnet.ibm.com>
IBM Linux Technology Center
On 03/24/2014 06:31 AM, shaohef(a)linux.vnet.ibm.com wrote:
> From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
>
> On firefox 27, the content of combobox and filterselect will hide.
>
> a similar problem on issue.
> https://github.com/kimchi-project/kimchi/issues/335
I didn't understand the relation between this patch an the issue
listed above.
I think actually *pradeepkumars
<https://github.com/pradeepkumars>* get
the NFS host and the pathl, but the content of these combo and select
are hidden.
It is about the follow section on my firefox 27.
Debug with Hongling, find the "overflow" is hide.
<section class="form-section">
<h2>3. $_("NFS Server IP")</h2>
<div class="field storage-field">
<p class="text-help">
$_("NFS server IP or hostname. It can
be input or chosen from history.")</p>
<div id="serverComboboxId"
class="storage-add-input-width">
<input id="nfsserverId"/>
<div>
<ul id="nfs-server-used">
</ul>
</div>
</div>
</div>
</section>
<section class="form-section">
<h2>4. $_("NFS Path")</h2>
<div class="field storage-field">
<p class="text-help">$_("The NFS
exported
path on NFS server.")</p>
<div id="targetFilterSelectId"
class="storage-add-input-width">
<input id="nfspathId"
class="input"
disabled/>
<div>
<ul id="nfs-server-target">
</ul>
</div>
</div>
</div>
</section>
>
> Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
> Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
> ---
> ui/css/theme-default/storage.css | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/ui/css/theme-default/storage.css
> b/ui/css/theme-default/storage.css
> index db3a62b..1139bd8 100644
> --- a/ui/css/theme-default/storage.css
> +++ b/ui/css/theme-default/storage.css
> @@ -578,3 +578,7 @@
> .storage-auth-width {
> width: 150px;
> }
> +
> +.storage-window .form-section .field {
> + overflow: visible;
> +}
Is it to show the combo box when it is at the end of the window?
9:14 p.m.
New subject: [PATCH 2/2] but fix: show the content of combobox and filterselect in storage add page
Reviewed-by: Aline Manera <alinefm(a)linux.vnet.ibm.com>
On 03/24/2014 06:31 AM, shaohef(a)linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
On firefox 27, the content of combobox and filterselect will hide.
a similar problem on issue.
https://github.com/kimchi-project/kimchi/issues/335
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
---
ui/css/theme-default/storage.css | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ui/css/theme-default/storage.css b/ui/css/theme-default/storage.css
index db3a62b..1139bd8 100644
--- a/ui/css/theme-default/storage.css
+++ b/ui/css/theme-default/storage.css
@@ -578,3 +578,7 @@
.storage-auth-width {
width: 150px;
}
+
+.storage-window .form-section .field {
+ overflow: visible;
+}
3:47 a.m.
Reviewed-by: Aline Manera <alinefm(a)linux.vnet.ibm.com>
On 03/24/2014 06:31 AM, shaohef(a)linux.vnet.ibm.com wrote:
From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
After we list the storage pools, it will change other element with the
same class attribute in other page.
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Signed-off-by: Hongliang Wang <hlwang(a)linux.vnet.ibm.com>
---
ui/js/src/kimchi.storage_main.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js
index c2c721d..6052510 100644
--- a/ui/js/src/kimchi.storage_main.js
+++ b/ui/js/src/kimchi.storage_main.js
@@ -49,7 +49,7 @@ kimchi.storageBindClick = function() {
}
});
- $('.active').each(function(index) {
+ $('.list-storage .storage-state .active').each(function(index) {
if ('active' === $(this).data('state')) {
$(this).show();
} else {
3932
days inactive
3934
days old
6 comments
3 participants
participants (3)
-
Aline Manera -
shaohef＠linux.vnet.ibm.com -
Sheldon