From: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; v1>v2, Improve feedback msg according to Hongliang's comments. Add loading icon to indicate nfs mount in progress, when error or normal response returns, close create window. Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;

--- ui/js/src/kimchi.storagepool_add_main.js | 2 ++ ui/pages/storagepool-add.html.tmpl | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js index 86dbe7f..6b77bd8 100644 --- a/ui/js/src/kimchi.storagepool_add_main.js +++ b/ui/js/src/kimchi.storagepool_add_main.js @@ -198,6 +198,7 @@ kimchi.validateNfsForm = function () { kimchi.message.error.code('KCHPOOL6005E'); return false; } + $('#nfs-mount-loading').removeClass('hidden'); return true; }; @@ -295,6 +296,7 @@ kimchi.addPool = function(event) { kimchi.window.close(); }, function(err) { kimchi.message.error(err.responseJSON.reason); + kimchi.window.close(); }); } } diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl index 977db66..b033b36 100644 --- a/ui/pages/storagepool-add.html.tmpl +++ b/ui/pages/storagepool-add.html.tmpl @@ -91,6 +91,12 @@ </ul> </div> </div> + <div class="hidden" id="nfs-mount-loading"> + <p class="text-help"> + $_("Trying to mount NFS export path. It may take several seconds.") + <img src = "../images/theme-default/loading.gif" /> + </p> + </div> </div> </section> </div>

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; v1>v2, Improve feedback msg according to Hongliang's comments. Add loading icon to indicate nfs mount in progress, when error or normal response returns, close create window. Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; --- ui/js/src/kimchi.storagepool_add_main.js | 2 ++ ui/pages/storagepool-add.html.tmpl | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js index 86dbe7f..6b77bd8 100644 --- a/ui/js/src/kimchi.storagepool_add_main.js +++ b/ui/js/src/kimchi.storagepool_add_main.js @@ -198,6 +198,7 @@ kimchi.validateNfsForm = function () { kimchi.message.error.code('KCHPOOL6005E'); return false; } + $('#nfs-mount-loading').removeClass('hidden'); return true; }; @@ -295,6 +296,7 @@ kimchi.addPool = function(event) { kimchi.window.close(); }, function(err) { kimchi.message.error(err.responseJSON.reason); + kimchi.window.close(); }); } } diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl index 977db66..b033b36 100644 --- a/ui/pages/storagepool-add.html.tmpl +++ b/ui/pages/storagepool-add.html.tmpl @@ -91,6 +91,12 @@ </ul> </div> </div> + <div class="hidden" id="nfs-mount-loading"> + <p class="text-help"> + $_("Trying to mount NFS export path. It may take several seconds.") + <img src = "../images/theme-default/loading.gif" /> + </p> + </div> </div> </section> </div>

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; v1>v2, Improve feedback msg according to Hongliang's comments. Add loading icon to indicate nfs mount in progress, when error or normal response returns, close create window. Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt; --- ui/js/src/kimchi.storagepool_add_main.js | 2 ++ ui/pages/storagepool-add.html.tmpl | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js index 86dbe7f..6b77bd8 100644 --- a/ui/js/src/kimchi.storagepool_add_main.js +++ b/ui/js/src/kimchi.storagepool_add_main.js @@ -198,6 +198,7 @@ kimchi.validateNfsForm = function () { kimchi.message.error.code('KCHPOOL6005E'); return false; } + $('#nfs-mount-loading').removeClass('hidden'); return true; }; @@ -295,6 +296,7 @@ kimchi.addPool = function(event) { kimchi.window.close(); }, function(err) { kimchi.message.error(err.responseJSON.reason); + kimchi.window.close(); }); } } diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl index 977db66..b033b36 100644 --- a/ui/pages/storagepool-add.html.tmpl +++ b/ui/pages/storagepool-add.html.tmpl @@ -91,6 +91,12 @@ </ul> </div> </div> + <div class="hidden" id="nfs-mount-loading"> + <p class="text-help"> + $_("Trying to mount NFS export path. It may take several seconds.") + <img src = "../images/theme-default/loading.gif" />

+ </p> + </div> </div> </section> </div>

On 05/30/2014 05:49 AM, Yu Xin Huo wrote: > 1. the location of this message indicate that it is only a progress > indicator of the 4th step? I tend to think it should be a progress > indicator of the whole pool generating process > 2. do not expect this kind of slow task to block whole UI. > 3. Please reference to "[Kimchi-devel] [PATCH] Issue #296 > [enhance]kimchi UI should not waiting while generating reports" to > handle it. > > > Is it important to explicit show a message? I thought in just change the mouse cursor to a loading one when selecting "Create" button > On 5/26/2014 11:21 AM, lvroyce(a)linux.vnet.ibm.com wrote: >> From: Royce Lv&lt;lvroyce(a)linux.vnet.ibm.com&gt; >> >> v1>v2, Improve feedback msg according to Hongliang's comments. >> >> Add loading icon to indicate nfs mount in progress, >> when error or normal response returns, >> close create window. >> >> Signed-off-by: Royce Lv&lt;lvroyce(a)linux.vnet.ibm.com&gt; >> --- >> ui/js/src/kimchi.storagepool_add_main.js | 2 ++ >> ui/pages/storagepool-add.html.tmpl | 6 ++++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js >> index 86dbe7f..6b77bd8 100644 >> --- a/ui/js/src/kimchi.storagepool_add_main.js >> +++ b/ui/js/src/kimchi.storagepool_add_main.js >> @@ -198,6 +198,7 @@ kimchi.validateNfsForm = function () { >> kimchi.message.error.code('KCHPOOL6005E'); >> return false; >> } >> + $('#nfs-mount-loading').removeClass('hidden'); >> return true; >> }; >> >> @@ -295,6 +296,7 @@ kimchi.addPool = function(event) { >> kimchi.window.close(); >> }, function(err) { >> kimchi.message.error(err.responseJSON.reason); >> + kimchi.window.close(); >> }); >> } >> } >> diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl >> index 977db66..b033b36 100644 >> --- a/ui/pages/storagepool-add.html.tmpl >> +++ b/ui/pages/storagepool-add.html.tmpl >> @@ -91,6 +91,12 @@ >> </ul> >> </div> >> </div> >> + <div class="hidden" id="nfs-mount-loading"> >> + <p class="text-help"> >> + $_("Trying to mount NFS export path. It may take several seconds.") >> + <img src = "../images/theme-default/loading.gif" /> > icon should be placed before text. >> + </p> >> + </div> >> </div> >> </section> >> </div> > > > > _______________________________________________ > Kimchi-devel mailing list > Kimchi-devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/kimchi-devel _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel