[PATCH v2] Fix break of deep scanning
From: Royce Lv <lvroyce@linux.vnet.ibm.com> Commit 265de8d7 forgot to add type 'kimchi-iso' to storage pool type, which prevents deep scannning to execute. Add it to API.json to fix this break. Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> --- src/kimchi/API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kimchi/API.json b/src/kimchi/API.json index 19b1c51..3281d2e 100644 --- a/src/kimchi/API.json +++ b/src/kimchi/API.json @@ -16,7 +16,7 @@ "type": { "description": "The type of the defined Storage Pool", "type": "string", - "pattern": "^dir|netfs|logical$", + "pattern": "^dir|netfs|logical|kimchi-iso$", "required": true }, "path": { -- 1.8.3.1
This is the same patch Royce sent a few days ago without the typo. Please push it to master ASAP so we can have deep scanning working again :) On 01/13/2014 01:53 PM, Daniel Barboza wrote:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
Commit 265de8d7 forgot to add type 'kimchi-iso' to storage pool type, which prevents deep scannning to execute. Add it to API.json to fix this break.
Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> --- src/kimchi/API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kimchi/API.json b/src/kimchi/API.json index 19b1c51..3281d2e 100644 --- a/src/kimchi/API.json +++ b/src/kimchi/API.json @@ -16,7 +16,7 @@ "type": { "description": "The type of the defined Storage Pool", "type": "string", - "pattern": "^dir|netfs|logical$", + "pattern": "^dir|netfs|logical|kimchi-iso$", "required": true }, "path": {
Reviewed-by: zhoumeina <zhoumein@linux.vnet.ibm.com> On 01/13/2014 11:57 PM, Daniel H Barboza wrote:
This is the same patch Royce sent a few days ago without the typo.
Please push it to master ASAP so we can have deep scanning working again :)
On 01/13/2014 01:53 PM, Daniel Barboza wrote:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
Commit 265de8d7 forgot to add type 'kimchi-iso' to storage pool type, which prevents deep scannning to execute. Add it to API.json to fix this break.
Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> --- src/kimchi/API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kimchi/API.json b/src/kimchi/API.json index 19b1c51..3281d2e 100644 --- a/src/kimchi/API.json +++ b/src/kimchi/API.json @@ -16,7 +16,7 @@ "type": { "description": "The type of the defined Storage Pool", "type": "string", - "pattern": "^dir|netfs|logical$", + "pattern": "^dir|netfs|logical|kimchi-iso$", "required": true }, "path": {
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
Reviewed-by: Royce Lv<lvroyce@linux.vnet.ibm.com> Thanks, Daniel! On 2014年01月13日 23:57, Daniel H Barboza wrote:
This is the same patch Royce sent a few days ago without the typo.
Please push it to master ASAP so we can have deep scanning working again :)
On 01/13/2014 01:53 PM, Daniel Barboza wrote:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
Commit 265de8d7 forgot to add type 'kimchi-iso' to storage pool type, which prevents deep scannning to execute. Add it to API.json to fix this break.
Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> --- src/kimchi/API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kimchi/API.json b/src/kimchi/API.json index 19b1c51..3281d2e 100644 --- a/src/kimchi/API.json +++ b/src/kimchi/API.json @@ -16,7 +16,7 @@ "type": { "description": "The type of the defined Storage Pool", "type": "string", - "pattern": "^dir|netfs|logical$", + "pattern": "^dir|netfs|logical|kimchi-iso$", "required": true }, "path": {
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
-- Reviewed-by: Paulo Vital <pvital@linux.vnet.ibm.com> On Mon, 2014-01-13 at 13:53 -0200, Daniel Barboza wrote:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
Commit 265de8d7 forgot to add type 'kimchi-iso' to storage pool type, which prevents deep scannning to execute. Add it to API.json to fix this break.
Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> --- src/kimchi/API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kimchi/API.json b/src/kimchi/API.json index 19b1c51..3281d2e 100644 --- a/src/kimchi/API.json +++ b/src/kimchi/API.json @@ -16,7 +16,7 @@ "type": { "description": "The type of the defined Storage Pool", "type": "string", - "pattern": "^dir|netfs|logical$", + "pattern": "^dir|netfs|logical|kimchi-iso$", "required": true }, "path": {
on 2014/01/13 23:53, Daniel Barboza wrote:
From: Royce Lv <lvroyce@linux.vnet.ibm.com>
Commit 265de8d7 forgot to add type 'kimchi-iso' to storage pool type, which prevents deep scannning to execute. Add it to API.json to fix this break.
Signed-off-by: Royce Lv <lvroyce@linux.vnet.ibm.com> Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> --- src/kimchi/API.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kimchi/API.json b/src/kimchi/API.json index 19b1c51..3281d2e 100644 --- a/src/kimchi/API.json +++ b/src/kimchi/API.json @@ -16,7 +16,7 @@ "type": { "description": "The type of the defined Storage Pool", "type": "string", - "pattern": "^dir|netfs|logical$", + "pattern": "^dir|netfs|logical|kimchi-iso$", "required": true }, "path": {
When I wrote 265de8d7, I read some code to determine if I should add kimchi-iso to the pattern. I thought it was a special case of dir pool. It proves me wrong. Sorry. -- Thanks and best regards! Zhou Zheng Sheng / 周征晟 E-mail: zhshzhou@linux.vnet.ibm.com Telephone: 86-10-82454397
participants (7)
-
Aline Manera -
Daniel Barboza -
Daniel H Barboza
-
Paulo Ricardo Paz Vital -
Royce Lv -
Zhou Zheng Sheng -
zhoumeina