[PATCH V2] [Kimchi] Added method for implementation of s390x boot detection

From: Archana Singh <archus@linux.vnet.ibm.com> Added method for implementation of s390x boot detection. And set bootable as True, so that creation of template can be proceeded, and once we will have actual implementation of this method follow up patch will be sent. Archana Singh (1): Added method for implementation of s390x boot detection. isoinfo.py | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.7.4

From: Archana Singh <archus@linux.vnet.ibm.com> Added method for implementation of s390x boot detection, however for now set bootable as True, and once we will figure out implementation follow up patch will be sent. Signed-off-by: Archana Singh <archus@linux.vnet.ibm.com> --- isoinfo.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/isoinfo.py b/isoinfo.py index d7ca044..6356698 100644 --- a/isoinfo.py +++ b/isoinfo.py @@ -395,6 +395,14 @@ lang=en#!/wiki/W51a7ffcf4dfd_4b40_9d82_446ebc23c550/page/PowerLinux\ # If reached this point the file wasn't found = not bootable self.bootable = False + def _scan_s390x(self): + """ + s390x firmware does not use the conventional El Torito boot + specification. This method will be used to check s390x image + is bootable or not. Till then this will set bootable True. + """ + self.bootable = True + def _scan_primary_vol(self, data): """ Scan one sector for a Primary Volume Descriptor and extract the @@ -445,6 +453,8 @@ lang=en#!/wiki/W51a7ffcf4dfd_4b40_9d82_446ebc23c550/page/PowerLinux\ self._scan_primary_vol(data) if platform.machine().startswith('ppc'): self._scan_ppc() + elif platform.machine().startswith('s390x'): + self._scan_s390x() else: self._scan_el_torito(data) -- 2.7.4

Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com> On 08/10/2016 03:15 AM, archus@linux.vnet.ibm.com wrote:
From: Archana Singh <archus@linux.vnet.ibm.com>
Added method for implementation of s390x boot detection. And set bootable as True, so that creation of template can be proceeded, and once we will have actual implementation of this method follow up patch will be sent.
Archana Singh (1): Added method for implementation of s390x boot detection.
isoinfo.py | 10 ++++++++++ 1 file changed, 10 insertions(+)

Applied to master. Thanks! On 08/10/2016 03:15 AM, archus@linux.vnet.ibm.com wrote:
From: Archana Singh <archus@linux.vnet.ibm.com>
Added method for implementation of s390x boot detection. And set bootable as True, so that creation of template can be proceeded, and once we will have actual implementation of this method follow up patch will be sent.
Archana Singh (1): Added method for implementation of s390x boot detection.
isoinfo.py | 10 ++++++++++ 1 file changed, 10 insertions(+)
participants (2)
-
archus@linux.vnet.ibm.com
-
Daniel Henrique Barboza