[PATCH] Issue 299 Inactive storage pools are listed while editing template
Omit any inactive pools from the template edit pool selection list. Signed-off-by: Adam King <rak@linux.vnet.ibm.com> --- ui/js/src/kimchi.storagepool_add_main.js | 2 +- ui/js/src/kimchi.template_edit_main.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js index 63c6d11..5960c8d 100644 --- a/ui/js/src/kimchi.storagepool_add_main.js +++ b/ui/js/src/kimchi.storagepool_add_main.js @@ -140,7 +140,7 @@ kimchi.validateForm = function() { kimchi.message.error.code('KCHPOOL6001E'); return false; } - if (name.contains("/")) { + if (name.indexOf("/")!=-1) { kimchi.message.error.code('KCHPOOL6004E'); return false; } diff --git a/ui/js/src/kimchi.template_edit_main.js b/ui/js/src/kimchi.template_edit_main.js index 5a928ae..17e9a41 100644 --- a/ui/js/src/kimchi.template_edit_main.js +++ b/ui/js/src/kimchi.template_edit_main.js @@ -30,7 +30,7 @@ kimchi.template_edit_main = function() { var options = []; if (result && result.length) { $.each(result, function(index, storagePool) { - if(storagePool.type !== 'kimchi-iso') { + if ((storagePool.state=="active") && (storagePool.type !== 'kimchi-iso')) { options.push({ label: storagePool.name, value: '/storagepools/' + storagePool.name -- 1.8.1.4
Reviewed-by: Aline Manera <alinefm@linux.vnet.ibm.com> On 02/27/2014 06:16 PM, Adam King wrote:
Omit any inactive pools from the template edit pool selection list.
Signed-off-by: Adam King <rak@linux.vnet.ibm.com> --- ui/js/src/kimchi.storagepool_add_main.js | 2 +- ui/js/src/kimchi.template_edit_main.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js index 63c6d11..5960c8d 100644 --- a/ui/js/src/kimchi.storagepool_add_main.js +++ b/ui/js/src/kimchi.storagepool_add_main.js @@ -140,7 +140,7 @@ kimchi.validateForm = function() { kimchi.message.error.code('KCHPOOL6001E'); return false; } - if (name.contains("/")) { + if (name.indexOf("/")!=-1) { kimchi.message.error.code('KCHPOOL6004E'); return false; } diff --git a/ui/js/src/kimchi.template_edit_main.js b/ui/js/src/kimchi.template_edit_main.js index 5a928ae..17e9a41 100644 --- a/ui/js/src/kimchi.template_edit_main.js +++ b/ui/js/src/kimchi.template_edit_main.js @@ -30,7 +30,7 @@ kimchi.template_edit_main = function() { var options = []; if (result && result.length) { $.each(result, function(index, storagePool) { - if(storagePool.type !== 'kimchi-iso') { + if ((storagePool.state=="active") && (storagePool.type !== 'kimchi-iso')) { options.push({ label: storagePool.name, value: '/storagepools/' + storagePool.name
On 2/28/2014 8:12 AM, Crístian Viana wrote:
Am 27-02-2014 18:16, schrieb Adam King:
- if (name.contains("/")) { + if (name.indexOf("/")!=-1) { A quick curious question: is there really a difference in those commands? I always thought "contains" was usually implemented as "indexOf != -1" anyway.
String.contains() is experimental function that doesn't work on all browsers, otherwise I would assume you are correct that its the same thing under the covers. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obj... -- Adam King <rak@linux.vnet.ibm.com> IBM C&SI
Am 28-02-2014 13:24, schrieb Adam King:
String.contains() is experimental function that doesn't work on all browsers, otherwise I would assume you are correct that its the same thing under the covers.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obj...
Thanks for the info!
participants (3)
-
Adam King -
Aline Manera -
Crístian Viana