[PATCH V2] [Kimchi] Added on_poweroff, on_reboot, on_crash tag to support s390x architecture.
From: Archana Singh <archus@linux.vnet.ibm.com> By default on_crash is destory, and if vm crashed then '/var/run/libvirt/qemu/%s.pid is deleted on s390x which in turn throw exception. So having on_crash tag with restart solve the issue. Archana Singh (1): Added on_poweroff, on_reboot, on_crash tag to also support s390x architecture. kvmusertests.py | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4
From: Archana Singh <archus@linux.vnet.ibm.com> By default on_crash is destory, and if vm crashed then '/var/run/libvirt/qemu/%s.pid is deleted on s390x which in turn throw exception. So having on_crash tag with restart solve the issue. Signed-off-by: Archana Singh <archus@linux.vnet.ibm.com> --- kvmusertests.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kvmusertests.py b/kvmusertests.py index 567955a..a3fb273 100644 --- a/kvmusertests.py +++ b/kvmusertests.py @@ -36,6 +36,9 @@ class UserTests(object): <type arch='%(arch)s'>hvm</type> <boot dev='hd'/> </os> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>restart</on_crash> </domain>""" lock = threading.Lock() user = None -- 2.7.4
Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com> On 08/10/2016 03:28 AM, archus@linux.vnet.ibm.com wrote:
From: Archana Singh <archus@linux.vnet.ibm.com>
By default on_crash is destory, and if vm crashed then '/var/run/libvirt/qemu/%s.pid is deleted on s390x which in turn throw exception. So having on_crash tag with restart solve the issue.
Archana Singh (1): Added on_poweroff, on_reboot, on_crash tag to also support s390x architecture.
kvmusertests.py | 3 +++ 1 file changed, 3 insertions(+)
ps: typo in commit msg will be amended before pushing it upstream. On 08/10/2016 03:41 PM, Daniel Henrique Barboza wrote:
Reviewed-by: Daniel Barboza <danielhb@linux.vnet.ibm.com>
On 08/10/2016 03:28 AM, archus@linux.vnet.ibm.com wrote:
From: Archana Singh <archus@linux.vnet.ibm.com>
By default on_crash is destory, and if vm crashed then '/var/run/libvirt/qemu/%s.pid is deleted on s390x which in turn throw exception. So having on_crash tag with restart solve the issue.
Archana Singh (1): Added on_poweroff, on_reboot, on_crash tag to also support s390x architecture.
kvmusertests.py | 3 +++ 1 file changed, 3 insertions(+)
Applied to master. Thanks! On 08/10/2016 03:28 AM, archus@linux.vnet.ibm.com wrote:
From: Archana Singh <archus@linux.vnet.ibm.com>
By default on_crash is destory, and if vm crashed then '/var/run/libvirt/qemu/%s.pid is deleted on s390x which in turn throw exception. So having on_crash tag with restart solve the issue.
Archana Singh (1): Added on_poweroff, on_reboot, on_crash tag to also support s390x architecture.
kvmusertests.py | 3 +++ 1 file changed, 3 insertions(+)
participants (2)
-
archus＠linux.vnet.ibm.com -
Daniel Henrique Barboza