Re: [Kimchi-devel] [PATCH] <Fix problems of edit a guest containssnapshots>
Hi,Crístian I've read your patch, which has solved the snapshots restore problems more clearly. I agree with you that we've already fixed this issue in separate patches, and I need to make some changes for the formatting issues and test case. My patch will be responsible for the url redirect problem, which modifies base.py and function 'revert' in vmsnapshots.py. Besides, I found there are two points need to pay attention to: 1. snap.listAllChildren() in _backup_snapshots.py need flag in older libvirt versions, as I used "0.10.2", it raised "listAllChildren() takes exactly 2 arguments (1 given)" 2. UI transfer param 'name' no matter you update vm name or not (of course while you edit a vm), so do we only need to bakup and restore the snapshots while vm name is really updated ? Best regards, Zongmei Gou
On 07-01-2015 23:38, Zongmei Gou wrote:
1. snap.listAllChildren() in _backup_snapshots.py need flag in older libvirt versions, as I used "0.10.2", it raised "listAllChildren() takes exactly 2 arguments (1 given)"
Great! I'll fix that.
2. UI transfer param 'name' no matter you update vm name or not (of course while you edit a vm), so do we only need to bakup and restore the snapshots while vm name is really updated ?
Well, IMO that's a UI bug. The UI shouldn't send the parameter 'name' when the VM name isn't changed. I think we should keep our patches like this (i.e. updating only the fields explicitly passed) and the UI should be updated later so it works better under the hood. I'll send the patch with the fix (1) above.
participants (2)
-
Crístian Viana -
Zongmei Gou