About the pre-integration test
Hi, After running the full unit-test cases by "sudo ./run_test.sh", I found the test cases were broken in all platforms including Fedora 20, Fedora 18, Ubuntu 12.04. I am not sure which patch broke it, but I think we should make sure all the existing unit-test cases passed before integration. To the maintainer, please enforce it when merging the patches. To the patch's submitter, please do a full unit test before submitting your patches into the mailing lists. It is very common for a new patch to trigger other test case's failure which seems non-related. Please make your code clean by the unit test cases. The unit test cases may take one minute, but it will save other's time in hours.
On 01/15/2014 06:05 AM, Shu Ming wrote:
Hi,
After running the full unit-test cases by "sudo ./run_test.sh", I found the test cases were broken in all platforms including Fedora 20, Fedora 18, Ubuntu 12.04.
I need to disagree. I am running kimchi on Ubuntu 13.10 and all tests passed.
I am not sure which patch broke it, but I think we should make sure all the existing unit-test cases passed before integration.
To the maintainer, please enforce it when merging the patches.
Thanks for the tip but I've already done that. But of course, I tested the patches in my system (Ubuntu 13.10) in which all the tests passed.
To the patch's submitter, please do a full unit test before submitting your patches into the mailing lists. It is very common for a new patch to trigger other test case's failure which seems non-related. Please make your code clean by the unit test cases. The unit test cases may take one minute, but it will save other's time in hours.
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
on 2014/01/15 16:05, Shu Ming wrote:
Hi,
After running the full unit-test cases by "sudo ./run_test.sh", I found the test cases were broken in all platforms including Fedora 20, Fedora 18, Ubuntu 12.04. I am not sure which patch broke it, but I think we should make sure all the existing unit-test cases passed before integration.
To the maintainer, please enforce it when merging the patches. To the patch's submitter, please do a full unit test before submitting your patches into the mailing lists. It is very common for a new patch to trigger other test case's failure which seems non-related. Please make your code clean by the unit test cases. The unit test cases may take one minute, but it will save other's time in hours.
I setup an internal Jenkins to run unit tests using root. If there is any failed tests I can also help reporting them to community. For now Jenkins says all tests are OK. Maybe you can provide error message of your failed tests and let's investigate how we can reproduce it.
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
-- Thanks and best regards! Zhou Zheng Sheng / 周征晟 E-mail: zhshzhou@linux.vnet.ibm.com Telephone: 86-10-82454397
In my FC18, several error were encountered at least. 1) .....libvirt: Storage Driver error : Storage pool not found: no storage pool with matching name 'kimchi-scanning-pool' libvirt: QEMU Driver error : Domain not found: no domain with matching name 'k墨屑kh墨-鈭ㄐ? libvirt: QEMU Driver error : Domain not found: no domain with matching name 'k墨屑kh墨-鈭ㄐ? ...........libvirt: Test Driver error : Network not found libvirt: Test Driver error : internal error network 'test-network' does not have a bridge name. .libvirt: Storage Driver error : Storage pool not found: no storage pool with matching name 'test-pool' .libvirt: Network Driver error : Network not found: no network with matching name 'no-exist' ..libvirt: Domain Config error : operation failed: domain 'kimchi-vm2' already exists with uuid 65032e33-69a6-4d33-9cf9-69fc7142c1d6 libvirt: QEMU Driver error : Domain not found: no domain with matching name 'kimchi-vm1' libvirt: QEMU Driver error : Domain not found: no domain with matching name 'kimchi-vm1' ..libvirt: error : this function is not supported by the connection driver: virDomainScreenshot libvirt: Test Driver error : Domain not found 2) ...............Failed to import plugin plugins.sample.Drawings 3) Feature tests are running endless, it might stop in a very long time in tens of minutes. ... *** Running feature tests *** 127.0.0.1 - - [16/Jan/2014:02:38:37] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:37] "GET /images/icon-fedora.png HTTP/1.1" 206 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:37] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" libvirt: Domain Config error : internal error unknown protocol type 'http' libvirt: Domain Config error : internal error unknown protocol type 'https' libvirt: Domain Config error : internal error unknown protocol type 'ftp' libvirt: Domain Config error : internal error unknown protocol type 'ftps' libvirt: Domain Config error : internal error unknown protocol type 'tftp' *** Feature tests completed *** *** Running feature tests *** 127.0.0.1 - - [16/Jan/2014:02:38:42] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:42] "GET /images/icon-fedora.png HTTP/1.1" 206 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:42] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" libvirt: Domain Config error : internal error unknown protocol type 'http' libvirt: Domain Config error : internal error unknown protocol type 'https' libvirt: Domain Config error : internal error unknown protocol type 'ftp' libvirt: Domain Config error : internal error unknown protocol type 'ftps' libvirt: Domain Config error : internal error unknown protocol type 'tftp' *** Feature tests completed *** 于 2014/1/16 13:46, Zhou Zheng Sheng:
on 2014/01/15 16:05, Shu Ming wrote:
Hi,
After running the full unit-test cases by "sudo ./run_test.sh", I found the test cases were broken in all platforms including Fedora 20, Fedora 18, Ubuntu 12.04. I am not sure which patch broke it, but I think we should make sure all the existing unit-test cases passed before integration.
To the maintainer, please enforce it when merging the patches. To the patch's submitter, please do a full unit test before submitting your patches into the mailing lists. It is very common for a new patch to trigger other test case's failure which seems non-related. Please make your code clean by the unit test cases. The unit test cases may take one minute, but it will save other's time in hours.
I setup an internal Jenkins to run unit tests using root. If there is any failed tests I can also help reporting them to community. For now Jenkins says all tests are OK. Maybe you can provide error message of your failed tests and let's investigate how we can reproduce it.
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
on 2014/01/16 15:17, Shu Ming wrote:
In my FC18, several error were encountered at least.
1) .....libvirt: Storage Driver error : Storage pool not found: no storage pool with matching name 'kimchi-scanning-pool' libvirt: QEMU Driver error : Domain not found: no domain with matching name 'k墨屑kh墨-鈭ㄐ? libvirt: QEMU Driver error : Domain not found: no domain with matching name 'k墨屑kh墨-鈭ㄐ? ...........libvirt: Test Driver error : Network not found libvirt: Test Driver error : internal error network 'test-network' does not have a bridge name. .libvirt: Storage Driver error : Storage pool not found: no storage pool with matching name 'test-pool' .libvirt: Network Driver error : Network not found: no network with matching name 'no-exist' ..libvirt: Domain Config error : operation failed: domain 'kimchi-vm2' already exists with uuid 65032e33-69a6-4d33-9cf9-69fc7142c1d6 libvirt: QEMU Driver error : Domain not found: no domain with matching name 'kimchi-vm1' libvirt: QEMU Driver error : Domain not found: no domain with matching name 'kimchi-vm1' ..libvirt: error : this function is not supported by the connection driver: virDomainScreenshot libvirt: Test Driver error : Domain not found
2) ...............Failed to import plugin plugins.sample.Drawings
3) Feature tests are running endless, it might stop in a very long time in tens of minutes. ... *** Running feature tests *** 127.0.0.1 - - [16/Jan/2014:02:38:37] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:37] "GET /images/icon-fedora.png HTTP/1.1" 206 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:37] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" libvirt: Domain Config error : internal error unknown protocol type 'http' libvirt: Domain Config error : internal error unknown protocol type 'https' libvirt: Domain Config error : internal error unknown protocol type 'ftp' libvirt: Domain Config error : internal error unknown protocol type 'ftps' libvirt: Domain Config error : internal error unknown protocol type 'tftp' *** Feature tests completed *** *** Running feature tests *** 127.0.0.1 - - [16/Jan/2014:02:38:42] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:42] "GET /images/icon-fedora.png HTTP/1.1" 206 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:42] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" libvirt: Domain Config error : internal error unknown protocol type 'http' libvirt: Domain Config error : internal error unknown protocol type 'https' libvirt: Domain Config error : internal error unknown protocol type 'ftp' libvirt: Domain Config error : internal error unknown protocol type 'ftps' libvirt: Domain Config error : internal error unknown protocol type 'tftp' *** Feature tests completed ***
I have the same problems actually, but they did not trigger test case failure, maybe those problems were swallowed by test code. As far as I know, Mark is working on fixing the second error.
于 2014/1/16 13:46, Zhou Zheng Sheng:
on 2014/01/15 16:05, Shu Ming wrote:
Hi,
After running the full unit-test cases by "sudo ./run_test.sh", I found the test cases were broken in all platforms including Fedora 20, Fedora 18, Ubuntu 12.04. I am not sure which patch broke it, but I think we should make sure all the existing unit-test cases passed before integration.
To the maintainer, please enforce it when merging the patches. To the patch's submitter, please do a full unit test before submitting your patches into the mailing lists. It is very common for a new patch to trigger other test case's failure which seems non-related. Please make your code clean by the unit test cases. The unit test cases may take one minute, but it will save other's time in hours.
I setup an internal Jenkins to run unit tests using root. If there is any failed tests I can also help reporting them to community. For now Jenkins says all tests are OK. Maybe you can provide error message of your failed tests and let's investigate how we can reproduce it.
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
-- Thanks and best regards! Zhou Zheng Sheng / 周征晟 E-mail: zhshzhou@linux.vnet.ibm.com Telephone: 86-10-82454397
On 01/16/2014 03:43 PM, Zhou Zheng Sheng wrote:
on 2014/01/16 15:17, Shu Ming wrote:
In my FC18, several error were encountered at least.
1) .....libvirt: Storage Driver error : Storage pool not found: no storage pool with matching name 'kimchi-scanning-pool' libvirt: QEMU Driver error : Domain not found: no domain with matching name 'k墨屑kh墨-鈭ㄐ? libvirt: QEMU Driver error : Domain not found: no domain with matching name 'k墨屑kh墨-鈭ㄐ? ...........libvirt: Test Driver error : Network not found libvirt: Test Driver error : internal error network 'test-network' does not have a bridge name. .libvirt: Storage Driver error : Storage pool not found: no storage pool with matching name 'test-pool' .libvirt: Network Driver error : Network not found: no network with matching name 'no-exist' ..libvirt: Domain Config error : operation failed: domain 'kimchi-vm2' already exists with uuid 65032e33-69a6-4d33-9cf9-69fc7142c1d6 libvirt: QEMU Driver error : Domain not found: no domain with matching name 'kimchi-vm1' libvirt: QEMU Driver error : Domain not found: no domain with matching name 'kimchi-vm1' ..libvirt: error : this function is not supported by the connection driver: virDomainScreenshot libvirt: Test Driver error : Domain not found
2) ...............Failed to import plugin plugins.sample.Drawings
3) Feature tests are running endless, it might stop in a very long time in tens of minutes. ... *** Running feature tests *** 127.0.0.1 - - [16/Jan/2014:02:38:37] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:37] "GET /images/icon-fedora.png HTTP/1.1" 206 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:37] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" libvirt: Domain Config error : internal error unknown protocol type 'http' libvirt: Domain Config error : internal error unknown protocol type 'https' libvirt: Domain Config error : internal error unknown protocol type 'ftp' libvirt: Domain Config error : internal error unknown protocol type 'ftps' libvirt: Domain Config error : internal error unknown protocol type 'tftp' *** Feature tests completed *** *** Running feature tests *** 127.0.0.1 - - [16/Jan/2014:02:38:42] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:42] "GET /images/icon-fedora.png HTTP/1.1" 206 4449 "" "" 127.0.0.1 - - [16/Jan/2014:02:38:42] "HEAD /images/icon-fedora.png HTTP/1.1" 200 4449 "" "" libvirt: Domain Config error : internal error unknown protocol type 'http' libvirt: Domain Config error : internal error unknown protocol type 'https' libvirt: Domain Config error : internal error unknown protocol type 'ftp' libvirt: Domain Config error : internal error unknown protocol type 'ftps' libvirt: Domain Config error : internal error unknown protocol type 'tftp' *** Feature tests completed ***
I have the same problems actually, but they did not trigger test case failure, maybe those problems were swallowed by test code. As far as I know, Mark is working on fixing the second error. These libvirt errors are no harmful. Because libvirt and kimchi are same stdout and errout
于 2014/1/16 13:46, Zhou Zheng Sheng:
on 2014/01/15 16:05, Shu Ming wrote:
Hi,
After running the full unit-test cases by "sudo ./run_test.sh", I found the test cases were broken in all platforms including Fedora 20, Fedora 18, Ubuntu 12.04. I am not sure which patch broke it, but I think we should make sure all the existing unit-test cases passed before integration.
To the maintainer, please enforce it when merging the patches. To the patch's submitter, please do a full unit test before submitting your patches into the mailing lists. It is very common for a new patch to trigger other test case's failure which seems non-related. Please make your code clean by the unit test cases. The unit test cases may take one minute, but it will save other's time in hours.
I setup an internal Jenkins to run unit tests using root. If there is any failed tests I can also help reporting them to community. For now Jenkins says all tests are OK. Maybe you can provide error message of your failed tests and let's investigate how we can reproduce it.
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
-- Thanks and best regards! Sheldon Feng(冯少合)<shaohef@linux.vnet.ibm.com> IBM Linux Technology Center
participants (4)
-
Aline Manera -
Sheldon -
Shu Ming -
Zhou Zheng Sheng