[PATCH] Fix opensuse OBS Build Error in the initd file
Signed-off-by: LiHaSo <rene.linder@lihaso.ch> --- contrib/wokd.sysvinit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/wokd.sysvinit b/contrib/wokd.sysvinit index 10680ee..b44ce7c 100644 --- a/contrib/wokd.sysvinit +++ b/contrib/wokd.sysvinit @@ -23,7 +23,7 @@ ### BEGIN INIT INFO # Provides: wokd # Required-Start: libvirtd -# Required-Stop: +# Required-Stop: libvirtd # Default-Start: 3 5 # Default-Stop: 0 1 2 6 # Description: Start the wokd daemon -- 2.6.0
Why are you requiring to stop libvirtd when stopping Wok/Kimchi? When stopping Wok or Kimchi and just want to stop this service. The required services can run with no problems. I can't see a good use case (or business value) to stop libvirt. Best regards, Paulo On Wed, 2015-10-14 at 13:14 +0200, LiHaSo wrote:
Signed-off-by: LiHaSo <rene.linder@lihaso.ch> --- contrib/wokd.sysvinit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/wokd.sysvinit b/contrib/wokd.sysvinit index 10680ee..b44ce7c 100644 --- a/contrib/wokd.sysvinit +++ b/contrib/wokd.sysvinit @@ -23,7 +23,7 @@ ### BEGIN INIT INFO # Provides: wokd # Required-Start: libvirtd -# Required-Stop: +# Required-Stop: libvirtd # Default-Start: 3 5 # Default-Stop: 0 1 2 6 # Description: Start the wokd daemon -- -- Paulo Ricardo Paz Vital IBM Linux Technology Center
If i understand the Debian/SUSE specs right, it only prevent libvirtd from stopping as long as kimchi/wok runs. And sorry if it's wrong, first time for me i deal with init.d scripts. then should the line be completely removed. René Linder Linder Hard- und Software On 14.10.2015 16:25, Paulo Ricardo Paz Vital wrote:
Why are you requiring to stop libvirtd when stopping Wok/Kimchi? When stopping Wok or Kimchi and just want to stop this service. The required services can run with no problems.
I can't see a good use case (or business value) to stop libvirt.
Best regards, Paulo
On Wed, 2015-10-14 at 13:14 +0200, LiHaSo wrote:
Signed-off-by: LiHaSo <rene.linder@lihaso.ch> --- contrib/wokd.sysvinit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/wokd.sysvinit b/contrib/wokd.sysvinit index 10680ee..b44ce7c 100644 --- a/contrib/wokd.sysvinit +++ b/contrib/wokd.sysvinit @@ -23,7 +23,7 @@ ### BEGIN INIT INFO # Provides: wokd # Required-Start: libvirtd -# Required-Stop: +# Required-Stop: libvirtd # Default-Start: 3 5 # Default-Stop: 0 1 2 6 # Description: Start the wokd daemon
Hello René On Wed, 2015-10-14 at 17:06 +0200, René Linder wrote:
If i understand the Debian/SUSE specs right, it only prevent libvirtd from stopping as long as kimchi/wok runs.
I just read better some guidelines and checked that "Required-Stop:" lists the "facilities which must be available during the shutdown of the service. The init-script system should avoid stopping init scripts which provide the Required-Stop facilities until this script is stopped". So, I understand it guarantees that libvirtd will be available during the shutdown process of Wok. It's OK to have this. Paulo.
And sorry if it's wrong, first time for me i deal with init.d scripts. then should the line be completely removed.
René Linder Linder Hard- und Software
On 14.10.2015 16:25, Paulo Ricardo Paz Vital wrote:
Why are you requiring to stop libvirtd when stopping Wok/Kimchi? When stopping Wok or Kimchi and just want to stop this service. The required services can run with no problems.
I can't see a good use case (or business value) to stop libvirt.
Best regards, Paulo
On Wed, 2015-10-14 at 13:14 +0200, LiHaSo wrote:
Signed-off-by: LiHaSo <rene.linder@lihaso.ch> --- contrib/wokd.sysvinit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/wokd.sysvinit b/contrib/wokd.sysvinit index 10680ee..b44ce7c 100644 --- a/contrib/wokd.sysvinit +++ b/contrib/wokd.sysvinit @@ -23,7 +23,7 @@ ### BEGIN INIT INFO # Provides: wokd # Required-Start: libvirtd -# Required-Stop: +# Required-Stop: libvirtd # Default-Start: 3 5 # Default-Stop: 0 1 2 6 # Description: Start the wokd daemon
On 14-10-2015 14:55, Paulo Ricardo Paz Vital wrote:
Hello René
On Wed, 2015-10-14 at 17:06 +0200, René Linder wrote:
If i understand the Debian/SUSE specs right, it only prevent libvirtd from stopping as long as kimchi/wok runs.
I just read better some guidelines and checked that "Required-Stop:" lists the "facilities which must be available during the shutdown of the service. The init-script system should avoid stopping init scripts which provide the Required-Stop facilities until this script is stopped".
So, I understand it guarantees that libvirtd will be available during the shutdown process of Wok. It's OK to have this.
Paulo.
Wok should not depend on libvirt. This is kimchi-specific. -- Lucio Correia Software Engineer IBM LTC Brazil
On 14/10/2015 14:59, Lucio Correia wrote:
On 14-10-2015 14:55, Paulo Ricardo Paz Vital wrote:
Hello René
On Wed, 2015-10-14 at 17:06 +0200, René Linder wrote:
If i understand the Debian/SUSE specs right, it only prevent libvirtd from stopping as long as kimchi/wok runs.
I just read better some guidelines and checked that "Required-Stop:" lists the "facilities which must be available during the shutdown of the service. The init-script system should avoid stopping init scripts which provide the Required-Stop facilities until this script is stopped".
So, I understand it guarantees that libvirtd will be available during the shutdown process of Wok. It's OK to have this.
Paulo.
Wok should not depend on libvirt. This is kimchi-specific.
Well remember, Lucio! Rene, Wok is the web server framework and Kimchi is now designed to be a plugin. On that way, wok service should not depend on libvirtd as it is only required to Kimchi. We need to think a way to get that problem solved. Paulo has sent a patch related to that for systemd system. You can take a look in the thread: http://lists.ovirt.org/pipermail/kimchi-devel/2015-October/011887.html It'd be good to have a similar (if possible) solution to all init scripts. Regards, Aline Manera
Hello Ok the Patch for the Wok sysvinit script should remove #Required-Stop: line and #Required-Start: empty (LSB 3.2 compilant ) Should i send a new Patch? Greetings René --- René Linder Linder Hard- und Software On 15.10.2015 00:01, Aline Manera wrote:
On 14/10/2015 14:59, Lucio Correia wrote:
On 14-10-2015 14:55, Paulo Ricardo Paz Vital wrote:
Hello René
On Wed, 2015-10-14 at 17:06 +0200, René Linder wrote:
If i understand the Debian/SUSE specs right, it only prevent libvirtd from stopping as long as kimchi/wok runs.
I just read better some guidelines and checked that "Required-Stop:" lists the "facilities which must be available during the shutdown of the service. The init-script system should avoid stopping init scripts which provide the Required-Stop facilities until this script is stopped".
So, I understand it guarantees that libvirtd will be available during the shutdown process of Wok. It's OK to have this.
Paulo.
Wok should not depend on libvirt. This is kimchi-specific.
Well remember, Lucio!
Rene,
Wok is the web server framework and Kimchi is now designed to be a plugin. On that way, wok service should not depend on libvirtd as it is only required to Kimchi. We need to think a way to get that problem solved. Paulo has sent a patch related to that for systemd system. You can take a look in the thread: http://lists.ovirt.org/pipermail/kimchi-devel/2015-October/011887.html
It'd be good to have a similar (if possible) solution to all init scripts.
Regards, Aline Manera
_______________________________________________ Kimchi-devel mailing list Kimchi-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/kimchi-devel
Reviewed-By: Paulo Vital <pvital@linux.vnet.ibm.com> On Wed, 2015-10-14 at 13:14 +0200, LiHaSo wrote:
Signed-off-by: LiHaSo <rene.linder@lihaso.ch> --- contrib/wokd.sysvinit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/wokd.sysvinit b/contrib/wokd.sysvinit index 10680ee..b44ce7c 100644 --- a/contrib/wokd.sysvinit +++ b/contrib/wokd.sysvinit @@ -23,7 +23,7 @@ ### BEGIN INIT INFO # Provides: wokd # Required-Start: libvirtd -# Required-Stop: +# Required-Stop: libvirtd # Default-Start: 3 5 # Default-Stop: 0 1 2 6 # Description: Start the wokd daemon
participants (5)
-
Aline Manera -
LiHaSo -
Lucio Correia -
Paulo Ricardo Paz Vital -
René Linder