4:37 a.m.
From: Rajat Gupta <rajat.triumph(a)gmail.com>
Rajat Gupta (3):
Fixed for Truncation occurs in edit a guest panel console row
Fixed Truncation appeared on Virtualization->add network of Japanese
language
Fixed truncation for Guest Interface GUI OVS network/interface scroll
bar
ui/css/src/modules/_edit-guests.scss | 2 +-
ui/css/src/modules/_network.scss | 8 ++++++++
ui/js/src/kimchi.guest_edit_main.js | 4 +++-
3 files changed, 12 insertions(+), 2 deletions(-)
--
2.1.0
4:37 a.m.
New subject: [PATCH] [Kimchi 1/3] Fixed for Truncation occurs in edit a guest panel console row
From: Rajat Gupta <rajat.triumph(a)gmail.com>
Fixed for Truncation occurs in edit a guest panel console row
Signed-off-by: Rajat Gupta <rajat.triumph(a)gmail.com>
---
ui/css/src/modules/_edit-guests.scss | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/css/src/modules/_edit-guests.scss b/ui/css/src/modules/_edit-guests.scss
index 25d4d65..fd43822 100644
--- a/ui/css/src/modules/_edit-guests.scss
+++ b/ui/css/src/modules/_edit-guests.scss
@@ -19,7 +19,7 @@
#guest-edit-window {
.tab-content {
overflow: hidden;
- height: 559px;
+ height: auto;
}
.tab-content .tab-pane {
position: relative;
--
2.1.0
4:37 a.m.
New subject: [PATCH] [Kimchi 2/3] Fixed Truncation appeared on Virtualization->add network of Japanese language
From: Rajat Gupta <rajat.triumph(a)gmail.com>
Fixed Truncation appeared on Virtualization->add network of Japanese language
Signed-off-by: Rajat Gupta <rajat.triumph(a)gmail.com>
---
ui/css/src/modules/_network.scss | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/ui/css/src/modules/_network.scss b/ui/css/src/modules/_network.scss
index 5cedb0f..cb39502 100644
--- a/ui/css/src/modules/_network.scss
+++ b/ui/css/src/modules/_network.scss
@@ -124,3 +124,11 @@
}
}
+
+#add-network-window {
+ #networkConfig {
+ #alert-modal-container .alert {
+ padding: 8px 34px 8px 16px;
+ }
+ }
+}
--
2.1.0
4:37 a.m.
New subject: [PATCH] [Kimchi 3/3] Fixed truncation for Guest Interface GUI OVS network/interface scroll bar
From: Rajat Gupta <rajat.triumph(a)gmail.com>
Fixed for Guest Interface GUI -- OVS network/interface scroll bar was
truncated when there are more than 20+ ovs bridges on the host.
Signed-off-by: Rajat Gupta <rajat.triumph(a)gmail.com>
---
ui/js/src/kimchi.guest_edit_main.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ui/js/src/kimchi.guest_edit_main.js b/ui/js/src/kimchi.guest_edit_main.js
index b47d293..bfc5c38 100644
--- a/ui/js/src/kimchi.guest_edit_main.js
+++ b/ui/js/src/kimchi.guest_edit_main.js
@@ -230,7 +230,9 @@ kimchi.guest_edit_main = function() {
$("select", "span.column-network",
itemNode).append(networkOptions);
}
- $("select", itemNode).selectpicker();
+ $("select", itemNode).selectpicker({
+ dropupAuto: false
+ });
$('.edit', itemNode).attr('disabled', kimchi.thisVMState ===
"running");
--
2.1.0
7:57 a.m.
Reviewed-By: Lucio Correia <luciojhc(a)linux.vnet.ibm.com>
On 24/01/2017 08:37, rajgupta(a)linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph(a)gmail.com>
Rajat Gupta (3):
Fixed for Truncation occurs in edit a guest panel console row
Fixed Truncation appeared on Virtualization->add network of Japanese
language
Fixed truncation for Guest Interface GUI OVS network/interface scroll
bar
ui/css/src/modules/_edit-guests.scss | 2 +-
ui/css/src/modules/_network.scss | 8 ++++++++
ui/js/src/kimchi.guest_edit_main.js | 4 +++-
3 files changed, 12 insertions(+), 2 deletions(-)
--
Lucio Correia
12:01 p.m.
New subject: [PATCH] [Kimchi 1/3] Fixed for Truncation occurs in edit a guest panel console row
You need to run "make -C ui/css css" to get the css updated as well and
added it to your commit.
On 01/24/2017 08:37 AM, rajgupta(a)linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph(a)gmail.com>
Fixed for Truncation occurs in edit a guest panel console row
Signed-off-by: Rajat Gupta <rajat.triumph(a)gmail.com>
---
ui/css/src/modules/_edit-guests.scss | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/css/src/modules/_edit-guests.scss b/ui/css/src/modules/_edit-guests.scss
index 25d4d65..fd43822 100644
--- a/ui/css/src/modules/_edit-guests.scss
+++ b/ui/css/src/modules/_edit-guests.scss
@@ -19,7 +19,7 @@
#guest-edit-window {
.tab-content {
overflow: hidden;
- height: 559px;
+ height: auto;
}
.tab-content .tab-pane {
position: relative;
12:01 p.m.
New subject: [PATCH] [Kimchi 2/3] Fixed Truncation appeared on Virtualization->add network of Japanese language
The same I commented related to the css file.
On 01/24/2017 08:37 AM, rajgupta(a)linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph(a)gmail.com>
Fixed Truncation appeared on Virtualization->add network of Japanese language
Signed-off-by: Rajat Gupta <rajat.triumph(a)gmail.com>
---
ui/css/src/modules/_network.scss | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/ui/css/src/modules/_network.scss b/ui/css/src/modules/_network.scss
index 5cedb0f..cb39502 100644
--- a/ui/css/src/modules/_network.scss
+++ b/ui/css/src/modules/_network.scss
@@ -124,3 +124,11 @@
}
}
+
+#add-network-window {
+ #networkConfig {
+ #alert-modal-container .alert {
+ padding: 8px 34px 8px 16px;
+ }
+ }
+}
12:03 p.m.
Please, also make sure to run "make check-local" to confirm everything
is on the place and also get the copyright date updated.
On 01/24/2017 08:37 AM, rajgupta(a)linux.vnet.ibm.com wrote:
From: Rajat Gupta <rajat.triumph(a)gmail.com>
Rajat Gupta (3):
Fixed for Truncation occurs in edit a guest panel console row
Fixed Truncation appeared on Virtualization->add network of Japanese
language
Fixed truncation for Guest Interface GUI OVS network/interface scroll
bar
ui/css/src/modules/_edit-guests.scss | 2 +-
ui/css/src/modules/_network.scss | 8 ++++++++
ui/js/src/kimchi.guest_edit_main.js | 4 +++-
3 files changed, 12 insertions(+), 2 deletions(-)
2636
days inactive
2646
days old
8 comments
3 participants
participants (3)
-
Aline Manera -
Lucio Correia -
rajgupta＠linux.vnet.ibm.com