On 05/18/2016 12:23 PM, Aline Manera wrote: > > Hi Daniel, > > The patch set looks good for me. > > I'd only recommend to you keep in touch with Socorro as it will > impact the edit virtual networks UI that she is working on. Just talked with her. She'll provide her inputs here when she is done rebasing/testing her work with the work I've done in this patch set. > > Please, send appropriate details on which is needed to edit a macvtap > passthrough mode if there is any difference from a macvtap bridge > network. There is no difference. The only difference is that the previous macvtap network provides a bridge to the guests, this new one will passthrough the network device to it. Usage is the same. > > Thanks, > Aline Manera > > On 05/17/2016 03:08 PM, dhbarboza82(a)gmail.com wrote: >> From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com&gt; >> >> This patch set adds a new forward mode called 'passthrough' to >> the 'macvtap' network. >> >> Docs, model, test and UI changes included. >> >> Daniel Henrique Barboza (3): >> Adding 'passthrough' forward mode to Macvtap: doc changes >> Adding 'passthrough' forward mode to Macvtap: model and test changes >> Adding 'passthrough' forward mode to Macvtap: UI changes >> >> API.json | 6 ++++++ >> docs/API.md | 1 + >> i18n.py | 1 + >> model/networks.py | 3 ++- >> tests/test_networkxml.py | 14 ++++++++++++++ >> ui/js/src/kimchi.network.js | 1 + >> ui/js/src/kimchi.network_add_main.js | 11 +++++++++-- >> ui/pages/network-add.html.tmpl | 3 ++- >> 8 files changed, 36 insertions(+), 4 deletions(-) >> >

What do you mean, Socorro? Care to give an example? On 05/18/2016 03:13 PM, Socorro Stoppler wrote: > In testing this patch, I found an issue in the creation of the > network. Even though a destination was chosen in the UI and the > network got created, using the curl command to check the networks, > interfaces did not have a value for it. > > Thanks > -Socorro > > On 05/18/2016 10:04 AM, Daniel Henrique Barboza wrote: >> >> >> On 05/18/2016 12:23 PM, Aline Manera wrote: >>> >>> Hi Daniel, >>> >>> The patch set looks good for me. >>> >>> I'd only recommend to you keep in touch with Socorro as it will >>> impact the edit virtual networks UI that she is working on. >> >> Just talked with her. She'll provide her inputs here when she is >> done rebasing/testing her work >> with the work I've done in this patch set. >> >>> >>> Please, send appropriate details on which is needed to edit a >>> macvtap passthrough mode if there is any difference from a macvtap >>> bridge network. >> >> There is no difference. The only difference is that the previous >> macvtap network provides a >> bridge to the guests, this new one will passthrough the network >> device to it. Usage is >> the same. >> >> >>> >>> Thanks, >>> Aline Manera >>> >>> On 05/17/2016 03:08 PM, dhbarboza82(a)gmail.com wrote: >>>> From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com&gt; >>>> >>>> This patch set adds a new forward mode called 'passthrough' to >>>> the 'macvtap' network. >>>> >>>> Docs, model, test and UI changes included. >>>> >>>> Daniel Henrique Barboza (3): >>>> Adding 'passthrough' forward mode to Macvtap: doc changes >>>> Adding 'passthrough' forward mode to Macvtap: model and test >>>> changes >>>> Adding 'passthrough' forward mode to Macvtap: UI changes >>>> >>>> API.json | 6 ++++++ >>>> docs/API.md | 1 + >>>> i18n.py | 1 + >>>> model/networks.py | 3 ++- >>>> tests/test_networkxml.py | 14 ++++++++++++++ >>>> ui/js/src/kimchi.network.js | 1 + >>>> ui/js/src/kimchi.network_add_main.js | 11 +++++++++-- >>>> ui/pages/network-add.html.tmpl | 3 ++- >>>> 8 files changed, 36 insertions(+), 4 deletions(-) >>>> >>> >> >