RE: oVirt site
-----Original Message-----
From: Carl Trieloff [mailto:cctrieloff@redhat.com]
Sent: Thursday, September 15, 2011 19:41 PM
To: Itamar Heim
Cc: 'Livnat Peer'; project-planning(a)ovirt.org; 'Carl Trieloff'
Subject: Re: oVirt site
On 09/15/2011 12:17 PM, Itamar Heim wrote:
> - need to decide if patch must be verified before submitting, or
> verification could be done as part of patch review (for example,
gerrit
> supports verification as part of flow. Some projects may prefer
this
> approach).
> - (using gerrit terminology) anyone can +1 a patch. only maintainer
can +2
> the patch. a +1 would help a maintainer do the +2.
> - going back to my earlier point on committer != maintainer: in a
large
> project, we'd still like committer to have right to commit
to entire
git
> to make things simple, but may have maintainers (or call them
sub
> maintainers) per module in the project. A committer would expect
(trust
> would suffice I hope) the relevant maintainer[1] to give the +2
before
> committing the patch[2]
Itamar,
Do you want to explicitly add the +2 for projects that use gerrit? I
can do that.
I agree with livnat we don't need it specifically. A +2 in gerrit is the
actual ack which is mentioned as +1.
(anyone can give a +1, maintainers can give a +2. The +1 helps the
maintainers with giving the +2 of course).
We can clarify this when we set it up with details on the process for the
projects using gerrit.
Carl.