9:05 a.m.
Hi,
I think I found a spelling bug in:
http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob_plain;f=vdsm_hooks/qos/b...
there are two occasions where "peak" is written as "peek".
Lines: 30, 35
--
Mit freundlichen Grüßen / Regards
Sven Kieske
Systemadministrator
Mittwald CM Service GmbH & Co. KG
Königsberger Straße 6
32339 Espelkamp
T: +49-5772-293-100
F: +49-5772-293-333
https://www.mittwald.de
Geschäftsführer: Robert Meyer
St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
3:38 a.m.
Hi Sven,
You can file a bug here for better tracking:
https://bugzilla.redhat.com/enter_bug.cgi?product=ovirt
----- Original Message -----
From: "Sven Kieske" <S.Kieske(a)mittwald.de>
To: users(a)ovirt.org
Sent: Wednesday, October 23, 2013 5:05:56 PM
Subject: [Users] [BUG] vdsm-hooks-qos
Hi,
I think I found a spelling bug in:
http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob_plain;f=vdsm_hooks/qos/b...
there are two occasions where "peak" is written as "peek".
Lines: 30, 35
--
Mit freundlichen Grüßen / Regards
Sven Kieske
Systemadministrator
Mittwald CM Service GmbH & Co. KG
Königsberger Straße 6
32339 Espelkamp
T: +49-5772-293-100
F: +49-5772-293-333
https://www.mittwald.de
Geschäftsführer: Robert Meyer
St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
_______________________________________________
Users mailing list
Users(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/users
4:07 a.m.
On Thu, Oct 24, 2013 at 04:38:28AM -0400, Alissa Bonas wrote:
Hi Sven,
You can file a bug here for better tracking:
https://bugzilla.redhat.com/enter_bug.cgi?product=ovirt
----- Original Message -----
> From: "Sven Kieske" <S.Kieske(a)mittwald.de>
> To: users(a)ovirt.org
> Sent: Wednesday, October 23, 2013 5:05:56 PM
> Subject: [Users] [BUG] vdsm-hooks-qos
>
> Hi,
>
> I think I found a spelling bug in:
>
http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob_plain;f=vdsm_hooks/qos/b...
>
> there are two occasions where "peak" is written as "peek".
>
> Lines: 30, 35
Thanks for this report. Since the fix is so easy, I am not sure that a
new BZ entry is needed.
Please note that as of ovirt-3.3, QoS is controllable my the main stream
(with NIC profiles) so the hook may not be necessary any longer.
Nonetheless, would you review/verify
http://gerrit.ovirt.org/20495
Regrads
Dan.
10:13 a.m.
Hi,
thanks for the quick fix!
The code looks good, I still have no gerrit account, maybe I should
create one (where and how?)
I'm aware of the 3.3 features, but we still stick with 3.2.3 here.
I hope we can give 3.3. another try when 3.3.1. is out, hopefully stable
enough!
PS: How do you get write access to the wiki?
Because the hook documentation is somewhat incomplete, and I could maybe
improve it already.
I also found no docs on how vdsm creates network devices for the vm in
libvirt (routed, switched, nat or forward mode etc.). Is there something
available I am not aware of? Maybe I just looked in the wrong
directions.
--
Mit freundlichen Grüßen / Regards
Sven Kieske
Systemadministrator
Mittwald CM Service GmbH & Co. KG
Königsberger Straße 6
32339 Espelkamp
T: +49-5772-293-100
F: +49-5772-293-333
https://www.mittwald.de
Geschäftsführer: Robert Meyer
St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
8:31 a.m.
On Thu, Oct 24, 2013 at 03:13:34PM +0000, Sven Kieske wrote:
Hi,
thanks for the quick fix!
The code looks good, I still have no gerrit account, maybe I should
create one (where and how?)
http://www.ovirt.org/Working_with_oVirt_Gerrit#Registering_as_a_user
I'm aware of the 3.3 features, but we still stick with 3.2.3 here.
I hope we can give 3.3. another try when 3.3.1. is out, hopefully stable
enough!
PS: How do you get write access to the wiki?
http://www.ovirt.org/Special:RequestAccount
Because the hook documentation is somewhat incomplete, and I could maybe
improve it already.
Please do!
I also found no docs on how vdsm creates network devices for the vm in
libvirt (routed, switched, nat or forward mode etc.). Is there something
available I am not aware of? Maybe I just looked in the wrong
directions.
I am afraid that we support only bridged connection. Implementing a hook
that provides fancier modes is a cool task.
Dan
10:24 a.m.
----- Original Message -----
From: "Dan Kenigsberg" <danken(a)redhat.com>
To: "Alissa Bonas" <abonas(a)redhat.com>
Cc: users(a)ovirt.org
Sent: Thursday, October 24, 2013 12:07:45 PM
Subject: Re: [Users] [BUG] vdsm-hooks-qos
On Thu, Oct 24, 2013 at 04:38:28AM -0400, Alissa Bonas wrote:
> Hi Sven,
>
> You can file a bug here for better tracking:
> https://bugzilla.redhat.com/enter_bug.cgi?product=ovirt
>
> ----- Original Message -----
> > From: "Sven Kieske" <S.Kieske(a)mittwald.de>
> > To: users(a)ovirt.org
> > Sent: Wednesday, October 23, 2013 5:05:56 PM
> > Subject: [Users] [BUG] vdsm-hooks-qos
> >
> > Hi,
> >
> > I think I found a spelling bug in:
> >
http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob_plain;f=vdsm_hooks/qos/b...
> >
> > there are two occasions where "peak" is written as "peek".
> >
> > Lines: 30, 35
Thanks for this report. Since the fix is so easy, I am not sure that a
new BZ entry is needed.
Please note that as of ovirt-3.3, QoS is controllable my the main stream
(with NIC profiles) so the hook may not be necessary any longer.
Nonetheless, would you review/verify
http://gerrit.ovirt.org/20495
Regrads
Dan.
Dan,
Is there a way to deprecate this starting 3.3.2 as we have an integrated solution?
5:12 a.m.
Hi,
please keep in mind to provide a sane upgrade path for the people
using vdsm-hook-qos if you deprecate it, thanks!
Am 24.10.2013 17:24, schrieb Doron Fediuck:
Dan,
Is there a way to deprecate this starting 3.3.2 as we have an integrated solution?
--
Mit freundlichen Grüßen / Regards
Sven Kieske
Systemadministrator
Mittwald CM Service GmbH & Co. KG
Königsberger Straße 6
32339 Espelkamp
T: +49-5772-293-100
F: +49-5772-293-333
https://www.mittwald.de
Geschäftsführer: Robert Meyer
St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
8:38 a.m.
On Fri, Oct 25, 2013 at 10:12:58AM +0000, Sven Kieske wrote:
Hi,
please keep in mind to provide a sane upgrade path for the people
using vdsm-hook-qos if you deprecate it, thanks!
Am 24.10.2013 17:24, schrieb Doron Fediuck:
> Dan,
> Is there a way to deprecate this starting 3.3.2 as we have an integrated solution?
Well, the hook has some benefits over NIC profiles (you can tweak any
parameter of any vnic with no global definitions), so I am guessing that
some would like to keep using it.
I suppose that we should link to http://www.ovirt.org/Features/Vnic_Profiles
from the hook readme, so that people would think twice before starting
to use the hook.
Dan.
9:46 a.m.
----- Original Message -----
From: "Dan Kenigsberg" <danken(a)redhat.com>
To: "Sven Kieske" <S.Kieske(a)mittwald.de>
Cc: users(a)ovirt.org, doron(a)redhat.com
Sent: Friday, October 25, 2013 4:38:50 PM
Subject: Re: [Users] [BUG] vdsm-hooks-qos
On Fri, Oct 25, 2013 at 10:12:58AM +0000, Sven Kieske wrote:
> Hi,
>
> please keep in mind to provide a sane upgrade path for the people
> using vdsm-hook-qos if you deprecate it, thanks!
>
> Am 24.10.2013 17:24, schrieb Doron Fediuck:
> > Dan,
> > Is there a way to deprecate this starting 3.3.2 as we have an integrated
> > solution?
>
Well, the hook has some benefits over NIC profiles (you can tweak any
parameter of any vnic with no global definitions), so I am guessing that
some would like to keep using it.
I suppose that we should link to http://www.ovirt.org/Features/Vnic_Profiles
from the hook readme, so that people would think twice before starting
to use the hook.
Dan.
Can you please refer me to the relevant readme? ie- is it in a wiki
or git?
4045
days inactive
4050
days old
8 comments
4 participants
participants (4)
-
Alissa Bonas -
Dan Kenigsberg -
Doron Fediuck -
Sven Kieske