[Engine-devel] Attaching a console should be controllable

[Andrew Cathrow]

----- Original Message -----
> From: "Roy Golan" <rgolan at redhat.com>
> To: engine-devel at ovirt.org
> Sent: Monday, December 10, 2012 1:31:55 PM
> Subject: Re: [Engine-devel] Attaching a console should be controllable
> 
> On 12/10/2012 02:28 PM, Frantisek Kobzik wrote:
> > Hi guys,
> >
> > Just a simple question. I'm writing an engine counterpart for this
> > vdsm feature:
> > https://bugzilla.redhat.com/show_bug.cgi?id=878459
> > http://gerrit.ovirt.org/#/c/9359
> >
> > Long story short, it adds the possibility of controlling adding the
> > virtio serial console to a VM.
> >
> > I'm going to add a new column "console_enabled" to vm_static and a

I'd make it serial_console since console can mean different things (eg vnc console, spice, etc)


> > new field "bool consoleEnabled" to appropriate entities. I'm just
> > worried about the naming of the column and the field - could I use
> > these names? Isn't it confusing? I just want to avoid unneeded
> > refactoring when the patch is done.
> both fits the convention - db columns underscored and java field
> camelCased.
> > Any feedback is welcome!
> >
> > Thanks,
> > Frank
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>